Skip to content

Avoid dodgy Rep (..) import in Cabal-syntax #9071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2023
Merged

Avoid dodgy Rep (..) import in Cabal-syntax #9071

merged 1 commit into from
Jun 30, 2023

Conversation

@RyanGlScott
Copy link
Member

@RyanGlScott RyanGlScott commented Jun 28, 2023

Fixes #9070.

Please include the following checklist in your PR:

Bonus points for added automated tests!

@RyanGlScott RyanGlScott mentioned this pull request Jun 28, 2023
Closed
ulysses4ever
ulysses4ever approved these changes Jun 28, 2023
View reviewed changes
Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted, thanks!

I believe this doesn't require a changelog or a test: this is not user visible at all.

@ulysses4ever
Copy link
Collaborator

ulysses4ever commented Jun 28, 2023 •
edited
Loading

We may want to backport it to 3.10 (and maybe try to squeeze it into 3.10.2) if we want 3.10 allow future GHCs. /cc @Kleidukos

3.8 is beyond salvation, perhaps...

@Kleidukos
Copy link
Member

Kleidukos commented Jun 28, 2023

Yes this can go in

@Kleidukos
Copy link
Member

Kleidukos commented Jun 28, 2023

@RyanGlScott thank you for this patch!

@ulysses4ever ulysses4ever added the merge me Tell Mergify Bot to merge label Jun 28, 2023
@ulysses4ever
Copy link
Collaborator

ulysses4ever commented Jun 28, 2023

As per the standard process, this will marinate for 2 days, and after that will be merged by the bot. Thanks!

@fgaz
Copy link
Member

fgaz commented Jun 28, 2023

@Mergifyio backport 3.10

@mergify
Copy link
Contributor

mergify bot commented Jun 28, 2023 •
edited
Loading

backport 3.10

✅ Backports have been created

@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Jun 30, 2023
@mergify mergify bot merged commit c03b50d into master Jun 30, 2023
@mergify mergify bot deleted the T9070 branch June 30, 2023 17:46
@mergify mergify bot mentioned this pull request Jun 30, 2023
Merged
ulysses4ever added a commit that referenced this pull request Jul 12, 2023
@ulysses4ever
Avoid dodgy Rep (..) import in Cabal-syntax (backport #9071) (#9077)
2722e81 
Avoid dodgy Rep (..) import in Cabal-syntax

Fixes #9070.

(cherry picked from commit ec75950)

# Conflicts:
#	Cabal-syntax/src/Distribution/Compat/Prelude.hs

* Merge branch '3.10' into mergify/bp/3.10/pr-9071
mergify bot added a commit that referenced this pull request Jul 12, 2023
@mergify
Merge pull request #9077 from haskell/mergify/bp/3.10/pr-9071
4bc59df 
Avoid dodgy Rep (..) import in Cabal-syntax (backport #9071)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ulysses4ever ulysses4ever ulysses4ever approved these changes

@ffaf1 ffaf1 ffaf1 approved these changes

Assignees

No one assigned

Labels

merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Suspicious Rep (..) import in Cabal-syntax's Distribution.Compat.Prelude

7 participants

@RyanGlScott @ulysses4ever @Kleidukos @fgaz @ffaf1 @Mikolaj