HookedBuildInfo can't update test suite build configuration

[rblaze]

preBuild hook allows to run some custom actions and update build configuration depending on it's results. In my case it was code generation. The problem is, it was test suite which needed generated modules, and HookedBuildInfo have only fields for updates to library and executables. Without update, test suite still builds, but cabal complains about generated not being added to other-modules list.

It would be great to be able to update configurations for all targets, including test suites.

[ezyang]

Confirmed, the culprit is updatePackageDescription in Distribution/PackageDescription.hs. I'd be very appreciative if you could upload a test case for this!

[ezyang]

I accidentally fixed this in af7bb53.

[ezyang]

I unfixed it because the change was not BC. See #3627