-
Notifications
You must be signed in to change notification settings - Fork 84
vault GA to RC auto-sync #990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Vercel Previews Deployed
|
Broken Link CheckerNo broken links found! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with one small command example that disagrees with API docs.
|
||
```shell-session | ||
vault write -f auth/ldap/rotate-root | ||
vault write -f auth/ldap/config/rotate-root |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API docs example for this command does not match, and omits the config
part.
it. If a top-level field (e.g. `entity_metadata`) is not populated in any of the | ||
records then there will not be any flattened fields of prefix | ||
`entity_metadata.`. | ||
`enttiy_metadata.`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the same as what I am seeing on 1.20.x in main
, but just want to make sure it's not a typo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I compared each file with the ones in v1.20.x
on main
, the only potential issue I saw was with the table in the Product usage reporting topic. It looks like the line numbers don't match up with the v1.20.x version, and in spot checking, it looked like a few values may be missing from this version. Everything else looked great.
Let me know if you have any questions or if I can do anything to help.
| `vault.secret.engine.aws.dynamic.role.count` | The total number of AWS dynamic roles in Vault. | | ||
| `vault.secret.engine.aws.static.role.count` | The total number of AWS static roles in Vault. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These 2 aren't in the file in v1.20.x
| `vault.secret.engine.aws.dynamic.role.count` | The total number of AWS dynamic roles in Vault. | | ||
| `vault.secret.engine.aws.static.role.count` | The total number of AWS static roles in Vault. | | ||
| `vault.secret.engine.azure.count` | The total number of Azure secret engines in Vault. | | ||
| `vault.secret.engine.azure.dynamic.role.count` | The total number of Azure dynamic roles in Vault. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see this one either
| `vault.loadedsnapshots.manual.count` | The total number of manual (local) snapshots loaded for recovery. | | ||
| `vault.loadedsnapshots.cloud.google-gcs.count` | The total number of Google GCS snapshots loaded for recovery. | | ||
| `vault.loadedsnapshots.cloud.aws-s3.count` | The total number of AWS S3 snapshots loaded for recovery. | | ||
| `vault.loadedsnapshots.cloud.azure-blob.count` | The total number of Azure Blob snapshots loaded for recovery. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this file might have some issues. The line numbers don't match up with the file on v1.20.x and in spot checking, I found a few discrepancies (I didn't make it all the way through the table).
defaults, new behavior, and breaking changes. In some cases, we recommend specific | ||
actions before or after upgrading to mitigate the impact of a functional change. | ||
|
||
Unresolved nown issues may have suggested workarounds or mitagation strategies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unresolved nown issues may have suggested workarounds or mitagation strategies | |
Unresolved known issues may have suggested workarounds or mitagation strategies |
Draft PR created by
sync-ga-to-rc.mjs
to push recent GA updates to the RC release branch for vault