Skip to content

Conversation

schavis
Copy link
Contributor

@schavis schavis commented Sep 23, 2025

Draft PR created by sync-ga-to-rc.mjs to push recent GA updates to the RC release branch for vault

@github-actions github-actions bot added Vault Content update for Vault product docs Vault IC Higher priority Vault content PR. Update relates to an important changes announcement. labels Sep 23, 2025
Copy link
Contributor

github-actions bot commented Sep 23, 2025

Vercel Previews Deployed

Name Status Preview Updated (UTC)
Dev Portal ✅ Ready (Inspect) Visit Preview Wed Sep 24 01:44:51 UTC 2025
Unified Docs API ✅ Ready (Inspect) Visit Preview Wed Sep 24 01:36:29 UTC 2025

Copy link
Contributor

github-actions bot commented Sep 24, 2025

Broken Link Checker

No broken links found! 🎉

@schavis schavis marked this pull request as ready for review September 24, 2025 01:24
@schavis schavis requested a review from a team as a code owner September 24, 2025 01:24
Copy link
Member

@brianshumate brianshumate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with one small command example that disagrees with API docs.


```shell-session
vault write -f auth/ldap/rotate-root
vault write -f auth/ldap/config/rotate-root
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API docs example for this command does not match, and omits the config part.

it. If a top-level field (e.g. `entity_metadata`) is not populated in any of the
records then there will not be any flattened fields of prefix
`entity_metadata.`.
`enttiy_metadata.`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same as what I am seeing on 1.20.x in main, but just want to make sure it's not a typo.

Copy link
Contributor

@Dan-Heath Dan-Heath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compared each file with the ones in v1.20.x on main, the only potential issue I saw was with the table in the Product usage reporting topic. It looks like the line numbers don't match up with the v1.20.x version, and in spot checking, it looked like a few values may be missing from this version. Everything else looked great.
Let me know if you have any questions or if I can do anything to help.

Comment on lines +172 to +173
| `vault.secret.engine.aws.dynamic.role.count` | The total number of AWS dynamic roles in Vault. |
| `vault.secret.engine.aws.static.role.count` | The total number of AWS static roles in Vault. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These 2 aren't in the file in v1.20.x

| `vault.secret.engine.aws.dynamic.role.count` | The total number of AWS dynamic roles in Vault. |
| `vault.secret.engine.aws.static.role.count` | The total number of AWS static roles in Vault. |
| `vault.secret.engine.azure.count` | The total number of Azure secret engines in Vault. |
| `vault.secret.engine.azure.dynamic.role.count` | The total number of Azure dynamic roles in Vault. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this one either

| `vault.loadedsnapshots.manual.count` | The total number of manual (local) snapshots loaded for recovery. |
| `vault.loadedsnapshots.cloud.google-gcs.count` | The total number of Google GCS snapshots loaded for recovery. |
| `vault.loadedsnapshots.cloud.aws-s3.count` | The total number of AWS S3 snapshots loaded for recovery. |
| `vault.loadedsnapshots.cloud.azure-blob.count` | The total number of Azure Blob snapshots loaded for recovery. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file might have some issues. The line numbers don't match up with the file on v1.20.x and in spot checking, I found a few discrepancies (I didn't make it all the way through the table).

defaults, new behavior, and breaking changes. In some cases, we recommend specific
actions before or after upgrading to mitigate the impact of a functional change.

Unresolved nown issues may have suggested workarounds or mitagation strategies
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Unresolved nown issues may have suggested workarounds or mitagation strategies
Unresolved known issues may have suggested workarounds or mitagation strategies

@schavis schavis marked this pull request as draft September 25, 2025 18:07
@schavis schavis closed this Oct 7, 2025
@schavis schavis deleted the bot/vault-ga-to-rc-sync branch October 7, 2025 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Vault IC Higher priority Vault content PR. Update relates to an important changes announcement. Vault Content update for Vault product docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants