-
Notifications
You must be signed in to change notification settings - Fork 80
[VAULT-38465] Cumulative API docs #1050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Vercel Previews Deployed
|
content/vault/v1.21.x (rc)/content/api-docs/system/internal-counters.mdx
Outdated
Show resolved
Hide resolved
content/vault/v1.21.x (rc)/content/api-docs/system/internal-counters.mdx
Outdated
Show resolved
Hide resolved
content/vault/v1.21.x (rc)/content/api-docs/system/internal-counters.mdx
Outdated
Show resolved
Hide resolved
content/vault/v1.21.x (rc)/content/api-docs/system/internal-counters.mdx
Outdated
Show resolved
Hide resolved
content/vault/v1.21.x (rc)/content/api-docs/system/internal-counters.mdx
Outdated
Show resolved
Hide resolved
content/vault/v1.21.x (rc)/content/api-docs/system/internal-counters.mdx
Outdated
Show resolved
Hide resolved
content/vault/v1.21.x (rc)/content/api-docs/system/internal-counters.mdx
Outdated
Show resolved
Hide resolved
content/vault/v1.21.x (rc)/content/api-docs/system/internal-counters.mdx
Outdated
Show resolved
Hide resolved
content/vault/v1.21.x (rc)/content/api-docs/system/internal-counters.mdx
Outdated
Show resolved
Hide resolved
content/vault/v1.21.x (rc)/content/api-docs/system/internal-counters.mdx
Outdated
Show resolved
Hide resolved
content/vault/v1.21.x (rc)/content/api-docs/system/internal-counters.mdx
Outdated
Show resolved
Hide resolved
content/vault/v1.21.x (rc)/content/api-docs/system/internal-counters.mdx
Show resolved
Hide resolved
|
||
```json | ||
{ | ||
"request_id": "b222b518-63a5-d1e7-39ee-216c0247833d", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be add an example with root as well that contains the cumulative sum
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean where the root namespace also has its own clients? I can replace this example with that if that's what you're looking for
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can have a common example scenario and two responses depending on which namespace the api is called from.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, I modified the scenario so the root namespace also has 50 clients, and now there's two sample requests/responses: one called from root, and one called from ns1
content/vault/v1.21.x (rc)/content/api-docs/system/internal-counters.mdx
Show resolved
Hide resolved
content/vault/v1.21.x (rc)/content/api-docs/system/internal-counters.mdx
Outdated
Show resolved
Hide resolved
…unters.mdx Co-authored-by: Sarah Chavis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions, LGTM
content/vault/v1.21.x (rc)/content/api-docs/system/internal-counters.mdx
Outdated
Show resolved
Hide resolved
content/vault/v1.21.x (rc)/content/api-docs/system/internal-counters.mdx
Outdated
Show resolved
Hide resolved
If the number of namespaces in the response approaches or exceeds the | ||
[default maximum](/vault/docs/internals/limits#namespace-limits), the request | ||
may take several seconds to complete. To prevent impacting the performance of | ||
your Vault cluster, avoid making multiple requests to the cumulative count | ||
endpoint at once. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we recommend that customers set a rate limit quota on this endpoint?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a mention of rate limit quotas
content/vault/v1.21.x (rc)/content/api-docs/system/internal-counters.mdx
Outdated
Show resolved
Hide resolved
content/vault/v1.21.x (rc)/content/api-docs/system/internal-counters.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Guilherme Santos <[email protected]>
Broken Link CheckerNo broken links found! 🎉 |
- `start_time` `(string, optional)` - An RFC3339 timestamp or Unix epoch time | ||
specifying the start of the client count query period. Leave `start_time` | ||
unset to use the billing start date as the start time. | ||
- `end_time` `(string, optional)` - An RFC3339 timestamp or Unix epoch time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing to mention here is that end_time is always the end of the billing period
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the wording to specify end of the billing period
|
||
### Parameters | ||
|
||
- `start_time` `(string, optional)` - An RFC3339 timestamp or Unix epoch time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarily, start_time will always be aligned to the start of a billing period
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the wording to specify start of the billing period
Add documentation for the new Cumulative namespace API introduced in https://github.com/hashicorp/vault-enterprise/pull/9186.
RFC: https://go.hashi.co/rfc/vlt-361