Skip to content

Conversation

blueberry-pi
Copy link
Contributor

Add documentation for the new Cumulative namespace API introduced in https://github.com/hashicorp/vault-enterprise/pull/9186.

RFC: https://go.hashi.co/rfc/vlt-361

@blueberry-pi blueberry-pi requested a review from divyaac October 3, 2025 16:12
@blueberry-pi blueberry-pi requested a review from a team as a code owner October 3, 2025 16:12
@blueberry-pi blueberry-pi added the Vault Content update for Vault product docs label Oct 3, 2025
Copy link

github-actions bot commented Oct 3, 2025

Vercel Previews Deployed

Name Status Preview Updated (UTC)
Dev Portal ✅ Ready (Inspect) Visit Preview Tue Oct 7 20:41:11 UTC 2025
Unified Docs API ✅ Ready (Inspect) Visit Preview Tue Oct 7 20:32:19 UTC 2025

@blueberry-pi blueberry-pi requested a review from akshya96 October 3, 2025 16:16
@blueberry-pi blueberry-pi requested a review from schavis October 6, 2025 17:50

```json
{
"request_id": "b222b518-63a5-d1e7-39ee-216c0247833d",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be add an example with root as well that contains the cumulative sum

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean where the root namespace also has its own clients? I can replace this example with that if that's what you're looking for

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can have a common example scenario and two responses depending on which namespace the api is called from.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, I modified the scenario so the root namespace also has 50 clients, and now there's two sample requests/responses: one called from root, and one called from ns1

Copy link
Contributor

@gsantos-hc gsantos-hc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions, LGTM

Comment on lines 1053 to 1057
If the number of namespaces in the response approaches or exceeds the
[default maximum](/vault/docs/internals/limits#namespace-limits), the request
may take several seconds to complete. To prevent impacting the performance of
your Vault cluster, avoid making multiple requests to the cumulative count
endpoint at once.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we recommend that customers set a rate limit quota on this endpoint?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a mention of rate limit quotas

Copy link

github-actions bot commented Oct 7, 2025

Broken Link Checker

No broken links found! 🎉

- `start_time` `(string, optional)` - An RFC3339 timestamp or Unix epoch time
specifying the start of the client count query period. Leave `start_time`
unset to use the billing start date as the start time.
- `end_time` `(string, optional)` - An RFC3339 timestamp or Unix epoch time
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to mention here is that end_time is always the end of the billing period

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the wording to specify end of the billing period


### Parameters

- `start_time` `(string, optional)` - An RFC3339 timestamp or Unix epoch time
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarily, start_time will always be aligned to the start of a billing period

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the wording to specify start of the billing period

@blueberry-pi blueberry-pi requested a review from divyaac October 7, 2025 17:01
@divyaac divyaac merged commit 9058679 into vault/1.21.x Oct 8, 2025
15 checks passed
@divyaac divyaac deleted the vault-38465-cumulative-api-docs branch October 8, 2025 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Vault Content update for Vault product docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants