adding docs updates for address_type changes #1047
Open
+9
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anwittin
approved these changes
Oct 3, 2025
schavis
requested changes
Oct 3, 2025
Comment on lines
+195
to
+197
| [go-discover](https://github.com/hashicorp/go-discover) syntax. Note: | ||
| Using `addr_typeaddress_type=private_v4` or `address_type=public_v4` will force IPv4 | ||
| addresses. |
There was a problem hiding this comment.
Suggested change
| [go-discover](https://github.com/hashicorp/go-discover) syntax. Note: | |
| Using `addr_typeaddress_type=private_v4` or `address_type=public_v4` will force IPv4 | |
| addresses. | |
| [go-discover](https://github.com/hashicorp/go-discover) syntax. Setting | |
| `addr_typeaddress_type=private_v4` or `address_type=public_v4` forces Vault to | |
| use IPv4 addresses. |
Style correction: prefer unified sentences over inline notes
Comment on lines
+195
to
+197
| [go-discover](https://github.com/hashicorp/go-discover) syntax. Note: | ||
| Using `addr_typeaddress_type=private_v4` or `address_type=public_v4` will force IPv4 | ||
| addresses. |
There was a problem hiding this comment.
Suggested change
| [go-discover](https://github.com/hashicorp/go-discover) syntax. Note: | |
| Using `addr_typeaddress_type=private_v4` or `address_type=public_v4` will force IPv4 | |
| addresses. | |
| [go-discover](https://github.com/hashicorp/go-discover) syntax. Setting | |
| `addr_typeaddress_type=private_v4` or `address_type=public_v4` forces Vault to | |
| use IPv4 addresses. |
Copied suggestion from 1.18.x doc
Comment on lines
+196
to
+198
| [go-discover](https://github.com/hashicorp/go-discover) syntax. Note: | ||
| Using `addr_typeaddress_type=private_v4` or `address_type=public_v4` will force IPv4 | ||
| addresses. |
There was a problem hiding this comment.
Suggested change
| [go-discover](https://github.com/hashicorp/go-discover) syntax. Note: | |
| Using `addr_typeaddress_type=private_v4` or `address_type=public_v4` will force IPv4 | |
| addresses. | |
| [go-discover](https://github.com/hashicorp/go-discover) syntax. Setting | |
| `addr_typeaddress_type=private_v4` or `address_type=public_v4` forces Vault to | |
| use IPv4 addresses. |
Copied suggestion from 1.18.x doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the docs to reflect forced ipv4