Use upstream net-http-persistent, connection_pool (un-vendored)
#345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This drops support for all EOL ruby versions.
Dropped 1.11: EOL since 2023-06-21 (last release was 2023-06-19) Dropped 1.12: EOL since 2023-09-27 (last release was 2023-09-11) Dropped 1.13: EOL since 2024-03-25 (last release was 2024-01-29) Added 1.14: EOL since 2024-06-10 (last release was 2024-02-28) Added 1.15: EOL since 2024-06-10 (last release was 2024-02-28) Added 1.16: EOL since 2024-06-10 (last release was 2024-05-29) Added 1.17: EOL since 2024-10-09 (last release was 2024-09-24) Added 1.18: current release (last release was 2025-01-29) 1.16 has LTS until 2026-03-15 (Vault Enterprise only). I kept unsupported releases all the way back to 1.14 only because I have to support a 1.14 server that hasn't been upgraded (yet). 😔
`net-http-persistent` and `connection_pool` were vendored, and have gotten very out-of-date. This resets to use the upstream gems. `connection-pool` is upgraded from 2.2.0 to 2.4+: * 2.2.5 fixes argument forwarding for ruby 2.7+. * 2.4.0 automatically drops all connections after fork. `net-http-persistent` is upgraded from 3.0.0 (forked) to 4.0.2+: * 4.0.2 fixes compatibility with `connection-pool` 2.4 * 3.1.0 supports TLS min/max and IPv6 (also in vendored fork) * 3.1.0 fixes a memory leak in connection pooling. * some vendored fork differences were removed: * use :name, :pool_size kwargs for .new One change to the vendored fork was reimplemented: upstream does _not_ support timeout kwarg for .new, nor does `connection_pool` expose an accessor for its `timeout`. So this code reaches into the pool and sets the `@timeout` ivar directly.
These exceptions are copied from the list of exceptions which Net::HTTP uses in `#transport_request` to determin whether the socket should be closed (and retried, for idempotent requests).
|
|
nevans
changed the title
net-http-persistent and connection_poolnet-http-persistent and connection_pool (un-vendored)
nevans
changed the title
net-http-persistent and connection_pool (un-vendored)net-http-persistent, connection_pool (un-vendored)
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
net-http-persistentandconnection_poolwere vendored, and have gotten very out-of-date. This resets to use the upstream gems.connection-poolis upgraded from 2.2.0 to 2.4+:net-http-persistentis upgraded from 3.0.0 (forked) to 4.0.2+:connection-pool2.4One change to the vendored fork was reimplemented: upstream does not support timeout kwarg for .new, nor does
connection_poolexpose an accessor for itstimeout. So this code reaches into the pool and sets the@timeoutivar directly.Additionally, all of the exceptions which
net-httphandles (inNet::HTTP#transport_request) are added toRESCUED_EXCEPTIONS. Net::HTTP uses these to determine whether the socket should be closed (and whether idempotent requests should be retried).Please note: this incorporates #346, so CI can pass.