Remove TF_ACC_TERRAFORM_VERSION from the GHA #2256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrhouston
approved these changes
Aug 31, 2023
4 tasks
korenyoni
added a commit
to codefresh-io/terraform-provider-codefresh
that referenced
this pull request
Oct 3, 2023
…Versions (#124) ## What * Concurrent provider acceptance tests against different terraform versions * Install Terraform beforehand, do not delegate Terraform SDK v2 to do download and install Terraform ## Why * There is an issue caused when parallel Terraform Provider acceptance tests install Terraform at the same time. Explained fairly well in hashicorp/terraform-provider-kubernetes#2256 * Better testing by using different versions of the Terraform binary (3 latest stable minor versions — their latest stable patch version resolved by [terraform-switcher](https://github.com/warrensbox/terraform-switcher) aka `tfswitch`) ## Notes * Will probably need to test against OpenTofu in the future ## Checklist * [x] _I have read [CONTRIBUTING.md](https://github.com/codefresh-io/terraform-provider-codefresh/blob/master/CONTRIBUTING.md)._ * [x] _I have [allowed changes to my fork to be made](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork)._ * [x] _I have added tests, assuming new tests are warranted_. * [x] _I understand that the `/test` comment will be ignored by the CI trigger [unless it is made by a repo admin or collaborator](https://codefresh.io/docs/docs/pipelines/triggers/git-triggers/#support-for-building-pull-requests-from-forks)._
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the env variable
TF_ACC_TERRAFORM_VERSIONfrom the acceptance test GHA to ensure the testing framework won't install anything and will use the binary installed in the previous steps.This should help avoiding the following issue:
failed to create new working directory: unable to disable terraform-exec provider verification: fork/exec /tmp/plugintest-terraform1868655341/terraform: text file busyAcceptance tests
Output from acceptance testing:
Release Note
Release note for CHANGELOG:
References
N/A.
Community Note