add delete Roles on kill storage #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ode cleanliness and efficiency
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| )?; | ||
| Self::remove_from_afloat_marketplace(account_id.clone())?; | ||
| UserInfo::<T>::remove(account_id); | ||
| } |
|
GPT summary of cb5f262:
PR summary so far:
|
…ve code readability and maintainability
| T::RemoveOrigin::ensure_origin(origin.clone()).is_ok(), | ||
| Error::<T>::NotAuthorized | ||
| ); | ||
| Self::do_remove_permission_from_pallet(pallet, permission_id)?; |
There was a problem hiding this comment.
GPT summary of d8dcfd - 04c864:
- Added a new call index 6 for the
remove_pallet_permissionsfunction - Added weight to the
remove_pallet_permissionsfunction - Added a check to ensure that the origin is authorized for the
remove_pallet_permissionsfunction - Added functionality to the
remove_pallet_permissionsfunction to remove pallet storage
|
GPT summary of a35edbe:
PR summary so far:
|
sebastianmontero
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.