Update dependencies to use Polkadot v1.0.0 #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r frame-support, frame-system, frame-benchmarking, sp-core, sp-io, sp-runtime, and sp-std 🚀 chore(bitcoin-vaults): update dependencies to use Polkadot v1.0.0 branch for frame-support, frame-system, frame-benchmarking, sp-core, sp-io, sp-runtime, and sp-std 🚀 chore(confidential-docs): update dependencies to use Polkadot v1.0.0 branch for frame-support, frame-system, and frame-benchmarking 🔀 chore(Cargo.toml): update substrate dependencies to use polkadot-v1.0.0 branch for fruniques, fund-admin-records, and fund-admin pallets 🔀 chore(Cargo.toml): update dependencies to use polkadot-v1.0.0 branch for frame-support, frame-system, frame-benchmarking, sp-runtime, pallet-uniques, pallet-balances, pallet-timestamp, sp-core, sp-io, and pallet-balances in gated-marketplace, mapped-assets, and rbac pallets 🔀 chore(Cargo.toml): update substrate dependencies to use polkadot-v1.0.0 branch for frame-support, frame-system, frame-benchmarking, sp-std, sp-core, sp-io, and sp-runtime to align with the latest version of Substrate framework
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| "percent-encoding", | ||
| ] | ||
|
|
||
| [[package]] |
| "derive", | ||
| ] } | ||
| serde = { version = "1.0.140", default-features = false, features = ["derive"] } | ||
| scale-info = { version = "2.1.1", default-features = false, features = [ |
There was a problem hiding this comment.
GPT summary of 34a988 - d236c4:
- Updated version of serde, scale-info, frame-support, frame-system, frame-benchmarking, sp-runtime, pallet-uniques, pallet-balances, pallet-timestamp, pallet-fruniques, pallet-rbac, pallet-gated-marketplace, and pallet-mapped-assets from polkadot-v0.9.40 to polkadot-v1.0.0.
- Updated version of sp-core, sp-io, sp-runtime, and sp-std from polkadot-v0.9.40 to polkadot-v1.0.0.
| ] } | ||
| serde = { version = "1.0.140", default-features = false, features = ["derive"] } | ||
| lite-json = { version = "0.1", default-features = false } | ||
| scale-info = { version = "2.1.1", default-features = false, features = [ |
There was a problem hiding this comment.
| codec = { package = "parity-scale-codec", version = "3.0.0", default-features = false, features = [ | ||
| "derive", | ||
| ] } | ||
| scale-info = { version = "2.1.1", default-features = false, features = [ |
There was a problem hiding this comment.
| codec = { package = "parity-scale-codec", version = "3.0.0", default-features = false, features = [ | ||
| "derive", | ||
| ] } | ||
| scale-info = { default-features = false, version = "2.0.1", features = [ |
There was a problem hiding this comment.
GPT summary of ef440b - d76a5a:
- Updated the version of codec to 3.0.0
- Updated the version of scale-info to 2.0.1
- Updated the versions of frame-support, frame-system, frame-benchmarking, sp-runtime, pallet-uniques, and pallet-balances to polkadot-v1.0.0
- Updated the version of sp-core to 7.0.0
- Updated the versions of sp-io to polkadot-v1.0.0
| codec = { package = "parity-scale-codec", version = "3.0.0", default-features = false, features = [ | ||
| "derive", | ||
| ] } | ||
| scale-info = { version = "2.0.1", default-features = false, features = [ |
There was a problem hiding this comment.
| codec = { package = "parity-scale-codec", version = "3.0.0", default-features = false, features = [ | ||
| "derive", | ||
| ] } | ||
| scale-info = { version = "2.0.1", default-features = false, features = [ |
There was a problem hiding this comment.
| "derive", | ||
| ] } | ||
| serde = { version = "1.0.140", default-features = false, features = ["derive"] } | ||
| scale-info = { version = "2.1.1", default-features = false, features = [ |
There was a problem hiding this comment.
|
|
||
| [dependencies] | ||
| codec = { package = "parity-scale-codec", version = "3.0.0", default-features = false } | ||
| scale-info = { version = "2.1.1", default-features = false, features = [ |
There was a problem hiding this comment.
| codec = { package = "parity-scale-codec", version = "3.0.0", default-features = false, features = [ | ||
| "derive", | ||
| ] } | ||
| scale-info = { version = "2.1.1", default-features = false, features = [ |
There was a problem hiding this comment.
GPT summary of 8fdf06 - 23cb28:
- Updated the version of
parity-scale-codecto3.0.0 - Updated the version of
scale-infoto2.1.1 - Updated the version of
frame-support,frame-system,frame-benchmarking, andsp-runtimefrompolkadot-v0.9.40topolkadot-v1.0.0 - Updated the version of
sp-coreandsp-iofrompolkadot-v0.9.40topolkadot-v1.0.0
| "derive", | ||
| ] } | ||
| log = { version = "0.4.14", default-features = false } | ||
| scale-info = { version = "2.1.1", default-features = false, features = [ |
There was a problem hiding this comment.
GPT summary of f27123 - 85df99:
- Updated versions of the following crates to
polkadot-v1.0.0branch:frame-support,frame-system,frame-benchmarking,sp-std,sp-core,sp-io, andsp-runtime - Updated version of
logcrate to0.4.14 - Updated version of
scale-infocrate to2.1.1 - Added
derivefeature toscale-infocrate - Updated default feature of
defaultcrate tostd
|
GPT summary of baf7428: Error: couldn't generate summary PR summary so far:
|
… for better readability 🔧 chore(rust-toolchain.toml): update Rust toolchain channel to nightly-2023-10-01 for compatibility with dependencies and add rustfmt component
| ); | ||
|
|
||
| // Update storage version | ||
| current_version.put::<Pallet<T>>(); |
|
GPT summary of be16e32:
PR summary so far:
|
| admin.clone(), | ||
| ); | ||
| if let Ok(collection_id) = collection_id { | ||
| AfloatCollectionId::<T>::put(collection_id); |
There was a problem hiding this comment.
GPT summary of 4c39a1 - 037753:
- Changed return type of
create_fruniques_collectionfromOk(())toErr(Error::FailedToCreateFruniquesCollection) - Changed comparison operator in
do_purchase_tax_creditfrom>=to> - Added semicolon to
do_purchase_tax_creditafterErr(Error::NotEnoughAfloatBalanceAvailable) - Added semicolon to
do_purchase_tax_creditafterErr(Error::TaxCreditAmountOverflow) - Added semicolon to
do_purchase_tax_creditafterErr(Error::Underflow)
| // build a vector containing owner + signers | ||
| let vault_members = vault.cosigners.to_vec(); | ||
| // iterate over that vector and add the vault id to the list of each user (signer) | ||
| vault_members.clone().into_iter().try_for_each(|acc| { |
There was a problem hiding this comment.
GPT summary of a963f9 - 046dcc:
- Added a check for the existence of an xpub when creating a vault
- Updated an error message for when a signer does not have permission to finalize a proposal
- Added a check to determine if an xpub is available for registration
- Updated a check to determine if a vault can be finalized
- Updated an error message for when a request fails
- Updated an error message for when a server error occurs
| /// so the code should be able to handle that. | ||
| fn offchain_worker(_block_number: T::BlockNumber) { | ||
| // check if the node has an account available, the offchain worker can't submit | ||
| // transactions without it |
| impl<T: Config> GroupMember<T> { | ||
| pub fn can_add_group_member(&self) -> bool { | ||
| self.role == GroupRole::Admin || self.role == GroupRole::Owner | ||
| } |
| class_id: &T::CollectionId, | ||
| instance_id: &T::ItemId, | ||
| key: &[u8], | ||
| ) -> AttributeValue<T> { |
There was a problem hiding this comment.
| parent_weight: Permill::from_percent(parent_info_call.parent_percentage), | ||
| is_hierarchical: parent_info_call.is_hierarchical, | ||
| }; | ||
|
|
| pub parent_weight: Permill, | ||
| pub is_hierarchical: bool, | ||
| } | ||
|
|
| // Ensure only Construction loan & developer equity drawdowns are able to call bulk upload | ||
| // extrinsic | ||
| let drawdown_data = | ||
| DrawdownsInfo::<T>::get(drawdown_id).ok_or(Error::<T>::DrawdownNotFound)?; |
There was a problem hiding this comment.
GPT summary of 5faf71 - 5ad228:
- Changed the way the roles of users are checked when assigning them to projects
- Updated error messages when trying to assign an administrator role account to a project
- Changed the way the status of drawdowns and revenues are checked when performing certain actions
- Updated error messages when trying to perform an action on a submitted drawdown or revenue
- Updated the way the status of revenue transactions is checked when performing certain actions
- Updated error messages when trying to perform an action on a submitted revenue transaction
- Updated the logic for transferring funds to users
| ) -> DrawdownId { | ||
| let mut drawdown_id: DrawdownId = [0; 32]; | ||
| let drawdonws_by_project = DrawdownsByProject::<Test>::get(project_id); | ||
|
|
There was a problem hiding this comment.
GPT summary of c9d233 - 51ad5c:
- Changed comparison logic in
get_drawdown_idandget_transaction_idfunctions, by removing redundant comparison statements. - Changed comparison logic in
get_revenue_transaction_idfunction, by removing redundant comparison statements. - In
expenditures_add_a_hard_cost_budget_expenditure_for_a_given_project_works,expenditures_add_a_softcost_budget_expenditure_for_a_given_project_works,expenditures_add_an_operational_budget_expenditure_for_a_given_project_works, andexpenditures_add_an_others_budget_expenditure_for_a_given_project_worksfunctions, added abreakstatement after the target expenditure is found. - In
expenditures_edit_a_given_expenditure_works,expenditures_admnistrator_tries_to_update_a_non_existent_expenditure_should_fail, andexpenditures_delete_a_selected_expenditure_worksfunctions, added abreakstatement after the target expenditure is found.
| }; | ||
| let applicant = match account_or_application.clone() { | ||
| AccountOrApplication::Account(acc) => acc, | ||
| AccountOrApplication::Application(application_id) => <ApplicationsByAccount<T>>::iter() |
There was a problem hiding this comment.
GPT summary of f6924d - ee3073:
- Changed the logic for fetching the account associated with an application
- Added a check to prevent owners from deleting themselves
- Added a check to ensure the price is valid when creating an offer
- Added a check to ensure the owner of an NFT is in the same marketplace as the caller making the offer
- Added a check to prevent approved applications from being rejected
- Changed the logic for deleting an application
- Added a check to ensure the offer type is SellOrder when creating an offer
- Added a check to ensure the owner is in the marketplace when enlisting a sell offer
- Added a check to ensure the owner is the one trying to redeem an NFT
| marketplace_id: MarketplaceId, | ||
| block_args: BlockUserArgs<T>, | ||
| ) -> DispatchResult { | ||
| let who = ensure_signed(origin)?; |
| m_id, | ||
| create_application_fields(2), | ||
| None | ||
| )); |
There was a problem hiding this comment.
GPT summary of e88400 - e159b7:
- Updated the logic for applying to a marketplace and enrolling in a marketplace
- Updated the logic for removing a marketplace, ensuring that the related storage is properly deleted for applicants with different statuses (pending, approved, rejected)
- Updated the logic for removing a marketplace, ensuring that the related storage is properly deleted for applications by account
| ) -> DepositConsequence { | ||
| let details = match Asset::<T, I>::get(id) { | ||
| Some(details) => details, | ||
| None => return DepositConsequence::UnknownAsset, |
There was a problem hiding this comment.
GPT summary of 98f0c4 - e9ffaf:
- Fixed return type of DepositConsequence::Overflow, DepositConsequence::BelowMinimum, DepositConsequence::CannotCreate, DepositConsequence::Overflow, Underflow, Frozen, Success, NoFunds, Frozen
- Fixed return type of Error::UnknownAsset, TokenError::BelowMinimum
- Added check for admin permission when transferring assets
- Added check for minimum balance when transferring assets
- Added check for frozen accounts when transferring assets
- Added check for insufficient balance when transferring assets
- Fixed check for overflow when transferring assets
| Account::<T, I>::try_mutate(id, who, |maybe_account| { | ||
| if let Some(extra) = maybe_extra { | ||
| // They want to write a value. Let this happen only if the account actually exists. | ||
| if let Some(ref mut account) = maybe_account { |
|
|
||
| Asset::<T, I>::try_mutate(id, |maybe_details| { | ||
| let details = maybe_details.as_mut().ok_or(Error::<T, I>::Unknown)?; | ||
| ensure!(details.status == AssetStatus::Live, Error::<T, I>::LiveAsset); |
| DepositRefunded, | ||
| } | ||
|
|
||
| impl<Balance> ExistenceReason<Balance> { |
| @@ -1,5 +0,0 @@ | |||
| [toolchain] | |||
|
GPT summary of 4dded4c: Error: couldn't generate summary PR summary so far:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r frame-support, frame-system, frame-benchmarking, sp-core, sp-io, sp-runtime, and sp-std
🚀 chore(bitcoin-vaults): update dependencies to use Polkadot v1.0.0 branch for frame-support, frame-system, frame-benchmarking, sp-core, sp-io, sp-runtime, and sp-std
🚀 chore(confidential-docs): update dependencies to use Polkadot v1.0.0 branch for frame-support, frame-system, and frame-benchmarking
🔀 chore(Cargo.toml): update substrate dependencies to use polkadot-v1.0.0 branch for fruniques, fund-admin-records, and fund-admin pallets
🔀 chore(Cargo.toml): update dependencies to use polkadot-v1.0.0 branch for frame-support, frame-system, frame-benchmarking, sp-runtime, pallet-uniques, pallet-balances, pallet-timestamp, sp-core, sp-io, and pallet-balances in gated-marketplace, mapped-assets, and rbac pallets
🔀 chore(Cargo.toml): update substrate dependencies to use polkadot-v1.0.0 branch for frame-support, frame-system, frame-benchmarking, sp-std, sp-core, sp-io, and sp-runtime to align with the latest version of Substrate framework.