add missing permissions in afloat #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ensure consistency with admin role assignment ✨ feat(lib.rs): add support for adding afloat and frunique roles during initial setup 🔧 chore(types.rs): add AddAfloatRole and AddFruniqueRole variants to InitialSetupArgs enum for role assignment
…at_frunique function call 🔧 chore(types): import FruniqueRole from pallet_fruniques to fix type error in InitialSetupArgs
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| ) -> DispatchResult { | ||
| //ensure user is registered | ||
| ensure!(UserInfo::<T>::contains_key(user_address.clone()), Error::<T>::UserNotFound); | ||
|
|
There was a problem hiding this comment.
GPT summary of ee955a - 4c39a1:
- Added a
give_role_to_user()function to give a user an AfloatRole of Admin - Added a
do_add_account_to_afloat_frunique()function to add an account to AfloatFrunique with a FruniqueRole of Admin - Added an event to deposit an
AdminAddedevent with the authority and user address
| Ok(()) | ||
| }, | ||
| InitialSetupArgs::Roles { creator, admin } => { | ||
| Self::do_setup_roles(creator, admin)?; |
| @@ -1,5 +1,6 @@ | |||
| use super::*; | |||
|
GPT summary of e04677f:
|
|
GPT summary of a6d2855:
PR summary so far:
|
…pallet` module The `spam_spawning` function was commented out and not being used. Removing it to improve code cleanliness and readability.
| let _ = <FruniqueRedeemed<T>>::clear(1000, None); | ||
| let _ = <FruniqueInfo<T>>::clear(1000, None); | ||
|
|
||
| T::Rbac::remove_pallet_storage(Self::pallet_id())?; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary so far:
AddAfloatRoleandAddFruniqueRolevariants to theInitialSetupArgsenumAddFruniqueRolefromAfloatRoletoFruniqueRolespam_spawning