Skip to content

Conversation

srush
Copy link
Collaborator

@srush srush commented Sep 12, 2021

This PR moves from the modifying tensors inline to instead using torch.where to create new ones.

This has a couple of advantages namely :

  • fixing the broken build code
  • removing lots of repeated semiring logic
  • unifying this with much of the jax code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant