REGTEST Added unit test for shutdown #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierresouchay
changed the title
Collaborator
|
This depends on #28 so I will wait for @ShimmerGlass to review that one before merging this. |
pierresouchay
force-pushed
the
added_unit_test_for_shutdown
branch
from
ac26634 to
52be57e
Compare
pierresouchay
force-pushed
the
added_unit_test_for_shutdown
branch
from
52be57e to
fa3b7b2
Compare
Collaborator
Author
|
@aiharos I rebased, this is fine now |
Collaborator
OK, do you still want to wait for a review from ShimmerGlass? |
Collaborator
Author
|
@aiharos No, it does not depend of API refactoring, this is fine to merge |
Collaborator
|
Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.