Reduce complex text #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few places use `enableKerning` and `requiresShaping` to decide on text rendering path, be that for rendering or only for measurement. Fixes: https://dev.haiku-os.org/ticket/19445
Set environment variable `HAIKUWEBKIT_COMPLEX_TEXT` to `DEBUGGER` to call the debugger on `ComplexTextController` creation.
|
It's getting annoying having to disable this in so many places. I wonder if it would be easier to fix the complex text path instead? Have you looked into it? (just to know and not duplicate work). |
|
Had the same idea but no, I haven't even looked at what may be needed yet. There's no hurry to merge this specifically. Current HEAD crashes on opening a URL in a new tab from the context menu, so I guess no release until that is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable complex text path in more cases and an environment variable protected call to debugger to detect issues that might be related to it.