Skip to content

Clean up if statements in gui.rs #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2023
Merged

Clean up if statements in gui.rs #23

merged 1 commit into from
Feb 20, 2023

Conversation

lonesometraveler
Copy link
Contributor

This should do the same as the original code.

But doesn't window always end up as 0 because self.plotting_range is set to -1 and never gets modified?

@hacknus
Copy link
Owner

hacknus commented Feb 20, 2023

self.plotting_range gets updated in the egui DragValue by a user input

@hacknus hacknus merged commit ad2419d into hacknus:main Feb 20, 2023
@lonesometraveler lonesometraveler deleted the clippy_16 branch February 28, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lonesometraveler @hacknus