This repository was archived by the owner on Jul 6, 2019. It is now read-only.
Fix #289: add examples to travis (and fix example fallout from #285) #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mcoffin
commented
May 31, 2015
mcoffin
commented
- Fixes Travis should attempt to build examples for the given platform. #289
- Fixes some issues with some examples that were introduced when Cargo Build System + Nightly Updates #285 landed.
Spelling problem in Cargo.toml Fallout from hackndev#285
| __aeabi_unwind_cpp_pr0 = abort; | ||
| __aeabi_unwind_cpp_pr1 = abort; | ||
| __aeabi_unwind_cpp_pr2 = abort; | ||
|
|
There was a problem hiding this comment.
This was the invisible fallout on the k20 platform created by #285. It didn't show up until we started compiling the examples in travis builds.
|
A minor comment notice, otherwise LGTM |
|
@farcaller Changed author in header. My bad I've just been pasting it. Saw approval from farcaller + travis. Merging. I'm not going to squash this, since the commits are actually fixing completely separate issues (adding examples to travis, fixing fallout from #285). It's a shame that ce3c4ac can't be squashed in to 7b8b395 but I'd rather have 1 extra commit than a very confusing git blame in the future. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.