Skip to content

fix: incorrect path when resolve to the same or the sub folder #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: incorrect path when resolve to the same or the sub folder #405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10ebad5
fix: incorrect path when resolve to the same or the sub folder
lake2 Nov 1, 2021
5650208
update a new version
lake2 Jan 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "@gulp-plugin/alias",
"name": "gulp-ts-alias-next",
"version": "2.2.2",
"description": "Use Gulp to resolve Typescript path aliases during compilation.",
"main": "./lib/index.js",
Expand Down
7 changes: 6 additions & 1 deletion src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,12 @@ function resolveImports(
const current = path.relative(base, path.dirname(imported.path))
const target = path.relative(base, resolved)

const relative = path.relative(current, target).replace(/\\/g, '/')
let relative = path.relative(current, target).replace(/\\/g, '/')
if (!relative.startsWith('..')) {
// https://github.com/gulp-plugin/alias/issues/404
// in the some folder or the sub folder
relative = './' + relative
}

lines[imported.index] = line.replace(imported.import, relative)
}
Expand Down
8 changes: 8 additions & 0 deletions test/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,14 @@ const tests: Record<string, Test> = {
input: "import module from 'module'\nimport Component from '@/components'",
output: "import module from 'module'\nimport Component from '../components'",
},
['should support wild card aliases : fix incorrect path when resolve to the same or the sub folder']:
// https://github.com/gulp-plugin/alias/issues/404
{
options: { config: { paths: { '@/*': ['./src/*'] } } },
path: './src/pages/Page.ts',
input: "import module from 'module'\nimport Component from '@/pages/components'",
output: "import module from 'module'\nimport Component from './components'",
},
['should skip commented imports']: {
options: { config },
path: './src/pages/Page.ts',
Expand Down