Skip to content

Conversation

@BDisp
Copy link
Collaborator

@BDisp BDisp commented Sep 8, 2022

Fixes #1999 - There were two bugs. Firstly on ScrollView which was returns false after the UngrabMouse even if the MouseEvent.View property isn't null and thus didn't run the view's mouse event. Secondly the mouseGrabView was run with the MouseEvent.View property equal to null. Now if the view is null the mouseGrabView will also be null by running the UngrabMouse method.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

Copy link
Collaborator

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ScrollView click sometimes throws when async-waiting for MainLoop-synched MessageBox

2 participants