Skip to content

Conversation

@kjin
Copy link
Contributor

@kjin kjin commented Dec 20, 2017

DNR

PropagateFlags and client.getChannel are added in future PRs.

@kjin kjin requested a review from murgatroid99 December 20, 2017 01:02
@kjin kjin removed the request for review from murgatroid99 December 20, 2017 01:22
@murgatroid99
Copy link
Member

I'm not sure how I feel about those changes to grpc-js. In the long run, at least, grpc-js-core and grpc-native-core should be exposing the same interfaces, and anything that doesn't depend on the low-level implementation should be implemented in grpc-surface.

@kjin
Copy link
Contributor Author

kjin commented Dec 20, 2017 via email

@kjin kjin closed this Jan 4, 2018
@thelinuxfoundation
Copy link

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
CLA GitHub bot

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants