grpc-js-core: compiler error and http2-facing fixes #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjin
changed the title
murgatroid99
approved these changes
Dec 8, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
channel.ts- We need to append the protocol to the incoming address parameter before it's turned into aURL(instead of after) - otherwise the hostname will be parsed as the protocol.call-credentials.ts/client.ts- Google TS style guide prohibits use ofObjecttypescall-stream.ts-headersdoesn't haveObjectprototype functions, soheaders.hasOwnPropertyfails. Also, destroying an http2 stream twice causes problemsmetadata.ts- compiler complains aboutvaluesbeing undefined, also I added a note on Node 8.8 serializing headers incorrectly