xds: support multiple xDS servers in bootstrap file #6493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapengzhang0
reviewed
Dec 6, 2019
|
|
||
| /** | ||
| * Returns the URI the traffic director to be connected to. | ||
| * Returns the list of connection configurations for traffic directors to be connected to. |
Contributor
There was a problem hiding this comment.
connection configurations is too specific, and is only true for the current user. Should be xDS server information
Contributor
Author
There was a problem hiding this comment.
Changed to "Returns the list of xDS servers to be connected to.". General enough.
| throw new IOException("Invalid bootstrap: 'channel_creds' contains unknown type."); | ||
| List<Map<String, ?>> serverConfigList = JsonUtil.checkObjectList(rawServerConfigs); | ||
| for (Map<String, ?> serverConfig : serverConfigList) { | ||
| // Field "server_uri" is required. |
Contributor
There was a problem hiding this comment.
This comment is redundant. The throwing exception is self-explaining.
dapengzhang0
approved these changes
Dec 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the future, the xDS bootstrap may provides multiple xDS server, with each has its own server URI and channel credential configurations. gRPC client will try to connect to them one by one until found the first reachable one. For now, we only support using the first one.
In this PR:
XdsClientIImplto take in a list of management servers.