-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[xDS] A97 - JWT token file call creds #12242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
a8f76b0
to
c781460
Compare
@ejona86 Could you please review this PR when you get a chance? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The shape of what I saw looked good. I didn't pay attention to any of the tests yet. I need to look through the provider plumbing more. But wanted to send the comments I have.
alts/src/main/java/io/grpc/alts/JwtTokenFileCallCredentials.java
Outdated
Show resolved
Hide resolved
alts/src/testFixtures/java/io/grpc/alts/JwtTokenFileTestUtils.java
Outdated
Show resolved
Hide resolved
alts/src/testFixtures/java/io/grpc/alts/JwtTokenFileTestUtils.java
Outdated
Show resolved
Hide resolved
xds/src/main/java/io/grpc/xds/internal/JwtTokenFileXdsCredentialsProvider.java
Outdated
Show resolved
Hide resolved
alts/src/main/java/io/grpc/alts/JwtTokenFileCallCredentials.java
Outdated
Show resolved
Hide resolved
alts/src/main/java/io/grpc/alts/JwtTokenFileCallCredentials.java
Outdated
Show resolved
Hide resolved
alts/src/main/java/io/grpc/alts/JwtTokenFileCallCredentials.java
Outdated
Show resolved
Hide resolved
c781460
to
85495b0
Compare
85495b0
to
9f97bb5
Compare
@ejona86 PR ready for second round |
implementing gRFC A97 grpc/proposal#492