Skip to content

Add call attributes to the authentication if no details are present #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2018
Merged

Add call attributes to the authentication if no details are present #160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...java/net/devh/boot/grpc/server/security/interceptors/AuthenticatingServerInterceptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@

import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.security.access.AccessDeniedException;
import org.springframework.security.authentication.AbstractAuthenticationToken;
import org.springframework.security.authentication.AnonymousAuthenticationToken;
import org.springframework.security.authentication.AuthenticationManager;
import org.springframework.security.authentication.BadCredentialsException;
Expand Down Expand Up @@ -69,6 +70,12 @@ public <ReqT, RespT> ServerCall.Listener<ReqT> interceptCall(final ServerCall<Re
throw new BadCredentialsException("No credentials found in the request", e);
}
}
if (authentication.getDetails() == null && authentication instanceof AbstractAuthenticationToken) {
// Append call attributes to the authentication request.
// This gives the AuthenticationManager access to information like remote and local address.
// It can then decide whether it wants to use its own user details or the attributes.
((AbstractAuthenticationToken) authentication).setDetails(call.getAttributes());
}
log.debug("Credentials found: Authenticating...");
authentication = this.authenticationManager.authenticate(authentication);
SecurityContextHolder.getContext().setAuthentication(authentication);
Expand Down