Skip to content

Repro for issue with extra carriage return #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Repro for issue with extra carriage return #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b862e07
Delete // yep yep
jcansdale Jun 1, 2017
b328e39
Add comment to first line
jcansdale Jun 1, 2017
5e502c6
add another line to comment on
jcansdale Jun 1, 2017
531c8d8
Add comment to `Program`
jcansdale Jun 1, 2017
cef5da1
Add a new first line
jcansdale Jun 1, 2017
effa20b
Add file with extra "\r"
jcansdale Oct 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions PullRequestSandbox/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,22 @@
using System;
// first line here


Copy link
Owner

@grokys grokys Apr 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deny



using System; // comment on first line
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;

namespace PullRequestSandbox
{
class Program
class Program // x
{
static void Main(string[] args)
{
/// yepyep
}
}
}

// another line to comment on
3 changes: 3 additions & 0 deletions PullRequestSandbox/PullRequestSandbox.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,9 @@
<ItemGroup>
<None Include="App.config" />
</ItemGroup>
<ItemGroup>
<Content Include="extra_carriage_return.txt" />
</ItemGroup>
<Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
<!-- To modify your build process, add your task inside one of the targets below and uncomment it.
Other similar extension points exist, see Microsoft.Common.targets.
Expand Down
2 changes: 2 additions & 0 deletions PullRequestSandbox/extra_carriage_return.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
foo
bar
Expand Down