This repository was archived by the owner on Aug 29, 2023. It is now read-only.
Remove double write #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mackosx I added the thread for future reference. |
ryanluker
reviewed
Apr 10, 2023
oauth2_provider/models.py
Outdated
| related_name="%(app_label)s_%(class)s", | ||
| ) | ||
| token = models.TextField(unique=True) | ||
| token = models.TextField(unique=True, null=True) |
There was a problem hiding this comment.
Do we want unique here anymore? I would have thought this would be null=True and blank=True
There was a problem hiding this comment.
blank just controls how it appears in the GSAdmin I think.. but I can update both!
There was a problem hiding this comment.
ryanluker
approved these changes
Apr 10, 2023
|
@ryanluker Going to merge this one so I can update the grnspace one. I think we are safe to merge that one to dev rightaway? |
Sure at this point I think that is safe enough! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Part 2 of https://app.shortcut.com/greenspace/story/77179/step-2-read-from-jti-instead-of-token-in-fork
Discussed below around do we need to be concerned about the unique -> null + blank migration?
https://app.shortcut.com/greenspace/story/77179/step-2-read-from-jti-instead-of-token-in-fork#activity-78426
Checklist