Skip to content
This repository was archived by the owner on Aug 29, 2023. It is now read-only.

Conversation

@mackosx
Copy link
Collaborator

@mackosx mackosx commented Apr 6, 2023

Ticket: https://app.shortcut.com/greenspace/story/77179/step-2-read-from-jti-instead-of-token-in-fork

Step 2 of our migration process.

  • read from jti value
  • increment version
  • add back null=False constraint (and default)

@mackosx mackosx changed the title Read from new value Read from new JTI value Apr 6, 2023
@mackosx mackosx requested a review from ryanluker April 6, 2023 21:03
Copy link

@ryanluker ryanluker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking as expected, maybe pull up a PR for the last commit hash in this PR inside the grnspace repo to make sure everything is good there too.

@mackosx
Copy link
Collaborator Author

mackosx commented Apr 10, 2023

Everything looks good in https://github.com/grnspace/greenspace/pull/9803, so we can merge this.

@ryanluker
Copy link

@mackosx I can merge and make the new release if you want to swap out the version in the other PR (maybe put it against the hotfix branch going out today?)

@ryanluker ryanluker merged commit c107d5d into master Apr 10, 2023
@ryanluker ryanluker deleted the 1.5.2-grn branch April 10, 2023 16:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants