Filtering results using filter library #128
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Franck LECUYER <[email protected]>
Signed-off-by: Franck LECUYER <[email protected]>
Contributor
|
FilterService doesn't extends AbstractFilterService so it has a lot of redundant code, shouldn't it be cleaned up by the way ? |
…Service class Signed-off-by: Franck LECUYER <[email protected]>
…ng_filter_library Signed-off-by: Franck LECUYER <[email protected]> # Conflicts: # src/main/java/org/gridsuite/voltageinit/server/service/parameters/FilterService.java
FranckLecuyer
force-pushed
the
filtering_results_using_filter_library
branch
from
a412f1a to
8b5a0a6
Compare
…Filters Signed-off-by: Franck LECUYER <[email protected]>
Meklo
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Using the code in the filter library for the results filtering (linked to PR : gridsuite/computation#13)