Refactor tests matchers #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tristan-WorkGH
force-pushed
the
rework_tests_matchers
branch
from
e639b47 to
1eb86c2
Compare
Tristan-WorkGH
force-pushed
the
rework_tests_matchers
branch
from
1eb86c2 to
1cbef3c
Compare
flomillot
reviewed
Jun 19, 2023
src/test/java/org/gridsuite/modification/server/utils/Assertions.java
Outdated
Show resolved
Hide resolved
...java/org/gridsuite/modification/server/utils/assertions/AbstractModificationInfosAssert.java
Outdated
Show resolved
Hide resolved
...java/org/gridsuite/modification/server/utils/assertions/AbstractModificationInfosAssert.java
Outdated
Show resolved
Hide resolved
| @Target(ElementType.TYPE) | ||
| @Retention(RetentionPolicy.RUNTIME) | ||
| @MockBeans({@MockBean(EmbeddedElasticsearch.class), @MockBean(EquipmentInfosRepository.class), @MockBean(TombstonedEquipmentInfosRepository.class)}) | ||
| @Tag("Docker") |
Contributor
There was a problem hiding this comment.
Why did you add tags, is it just for informational purposes or it's planned to be used in the CI/CD ?
Contributor
Author
There was a problem hiding this comment.
It's to distinct units tests from integration tests, as they aren't separated in folders (like tests\, it-tests`). It also permit to run for example unit tests quickly.
Contributor
There was a problem hiding this comment.
Ok, I used tags too before to optimise CI/CD runtime, but here it's not used so I was wondering the purpose
flomillot
approved these changes
Jun 27, 2023
Tristan-WorkGH
force-pushed
the
rework_tests_matchers
branch
from
b2ea30b to
bd19c43
Compare
SlimaneAmar
approved these changes
Jul 3, 2023
SlimaneAmar
force-pushed
the
rework_tests_matchers
branch
from
16c7488 to
a8f8ebd
Compare
Signed-off-by: Slimane AMAR <[email protected]>
SlimaneAmar
force-pushed
the
rework_tests_matchers
branch
from
58f19a7 to
5f105b5
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppress/Simplify various matchers in hypothesis application tests