Skip to content

Replace Chip with OverflowableChip in global filter components #3463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Replace Chip with OverflowableChip in global filter components #3463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f2a5c2
Replace `Chip` with `OverflowableChip` in global filter components
flomillot Nov 13, 2025
3fc4d10
Merge branch 'main' into use-new-overflowable-chip
flomillot Nov 13, 2025
2eaa2e7
Merge branch 'main' into use-new-overflowable-chip
flomillot Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/components/results/common/global-filter/global-filter-autocomplete.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import { useLocalizedCountries } from 'components/utils/localized-countries-hook
import { useSelector } from 'react-redux';
import { AppState } from '../../../../redux/reducer';
import { FilterType } from '../utils';
import { OverflowableText } from '@gridsuite/commons-ui';
import { OverflowableText, OverflowableChip } from '@gridsuite/commons-ui';
import { EQUIPMENT_TYPES } from '../../../utils/equipment-types';
import { GlobalFilter } from './global-filter-types';
import { getResultsGlobalFiltersChipStyle, resultsGlobalFilterStyles } from './global-filter-styles';
Expand Down Expand Up @@ -223,8 +223,7 @@ function GlobalFilterAutocomplete({
const key: string = `inputFieldChip_${element.label}`;
if (index < TAG_LIMIT_NUMBER) {
return (
<Chip
size="small"
<OverflowableChip
label={label}
{...getTagsProps({ index })}
key={key}
Expand Down
4 changes: 2 additions & 2 deletions src/components/results/common/global-filter/global-filter-paper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
fetchElementsInfos,
mergeSx,
TreeViewFinderNodeProps,
OverflowableChip

Check warning on line 32 in src/components/results/common/global-filter/global-filter-paper.tsx

View workflow job for this annotation

GitHub Actions / build / build 

Insert `,`
Copy link
Contributor

@thangqp thangqp Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
OverflowableChip
OverflowableChip,

} from '@gridsuite/commons-ui';
import { GlobalFilterContext } from './global-filter-context';

Expand Down Expand Up @@ -213,8 +214,7 @@
<List sx={mergeSx(resultsGlobalFilterStyles.list, { overflowY: 'auto' })}>
{selectedGlobalFilters.map((element: GlobalFilter) => (
<ListItem key={element.label} sx={{ height: '1.8em' }}>
<Chip
size="small"
<OverflowableChip
label={getOptionLabel(element, translate)}
sx={getResultsGlobalFiltersChipStyle(element.filterType)}
onDelete={() => {
Expand Down
Loading