Skip to content

Conversation

@AbdelHedhili
Copy link
Contributor

No description provided.

@AbdelHedhili AbdelHedhili self-assigned this Feb 7, 2024
@jamal-khey jamal-khey self-requested a review February 7, 2024 09:21
Copy link
Contributor

@jamal-khey jamal-khey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test and code Ok

@flomillot
Copy link
Contributor

flomillot commented Feb 8, 2024

In meeting last time we said we should create a new hook inside commons-ui instead of duplicating the code in both gridstudy and gridexplore.
We already have something similar that we could ajust or get inspiration from, and it's something we need in every front app.
https://github.com/gridsuite/commons-ui/blob/520b575880b7bb5fbe582d34a0f4b924b9274573/src/hooks/useSnackMessage.js#L12

@AbdelHedhili AbdelHedhili reopened this Feb 8, 2024
@AbdelHedhili
Copy link
Contributor Author

In meeting last time we said we should create a new hook inside commons-ui instead of duplicating the code in both gridstudy and gridexplore. We already have something similar that we could ajust or get inspiration from, and it's something we need in every front app. https://github.com/gridsuite/commons-ui/blob/520b575880b7bb5fbe582d34a0f4b924b9274573/src/hooks/useSnackMessage.js#L12

agreed, it was just a fast first version. We can do the refacto in another or in this one if you prefer to use commons-ui

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants