add pcc min parameters #920
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SOUISSI Maissa (Externe) <[email protected]>
sBouzols
reviewed
Nov 13, 2025
| * License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| * file, You can obtain one at http://mozilla.org/MPL/2.0/. | ||
| */ | ||
| import type { UUID } from 'node:crypto'; |
Contributor
There was a problem hiding this comment.
Move this file into src/services
sBouzols
reviewed
Nov 13, 2025
src/services/pcc-min.ts
Outdated
|
|
||
| export function updatePccMinParameters(studyUuid: UUID | null, newParams: PccMinParameters | null) { | ||
| console.info('set study pcc min parameters'); | ||
| const url = `${PREFIX_STUDY_QUERIES}/v1/studies/${studyUuid}/pcc-min/parameters`; |
Contributor
There was a problem hiding this comment.
Suggested change
| const url = `${PREFIX_STUDY_QUERIES}/v1/studies/${studyUuid}/pcc-min/parameters`; | |
| const url = `${getStudyUrl(studyUuid)}/pcc-min/parameters`; |
sBouzols
reviewed
Nov 13, 2025
Comment on lines
32
to
47
| // GridExplore versus GridStudy exclusive input params | ||
| type UsePccMinParametersFormProps = | ||
| | { | ||
| parametersUuid: UUID; | ||
| name: string; | ||
| description: string | null; | ||
| studyUuid: null; | ||
| parameters: null; | ||
| } | ||
| | { | ||
| parametersUuid: null; | ||
| name: null; | ||
| description: null; | ||
| studyUuid: UUID | null; | ||
| parameters: PccMinParameters | null; | ||
| }; |
Contributor
There was a problem hiding this comment.
Maybe keep it simple, we don't manage GridExplore edition for now
Suggested change
| // GridExplore versus GridStudy exclusive input params | |
| type UsePccMinParametersFormProps = | |
| | { | |
| parametersUuid: UUID; | |
| name: string; | |
| description: string | null; | |
| studyUuid: null; | |
| parameters: null; | |
| } | |
| | { | |
| parametersUuid: null; | |
| name: null; | |
| description: null; | |
| studyUuid: UUID | null; | |
| parameters: PccMinParameters | null; | |
| }; | |
| type UsePccMinParametersFormProps = { | |
| parametersUuid: UUID | null; | |
| name: string | null; | |
| description: string | null; | |
| studyUuid: UUID | null; | |
| parameters: PccMinParameters | null; | |
| }; |
sBouzols
reviewed
Nov 13, 2025
Comment on lines
+94
to
+96
| const timer = setTimeout(() => { | ||
| setParamsLoading(true); | ||
| }, 700); |
Contributor
There was a problem hiding this comment.
Why ? Why do we need to wait 700ms to set that params are loading ?
Signed-off-by: SOUISSI Maissa (Externe) <[email protected]>
added 2 commits
November 13, 2025 21:27
Signed-off-by: SOUISSI Maissa (Externe) <[email protected]>
Signed-off-by: SOUISSI Maissa (Externe) <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary