fixed cellHeight() check for no-op return #786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the code that checked for cell height and unit being the same was incorrect. Testing Done: calling this should be no-op, but wasn't this.grid.cellHeight( this.grid.cellHeight() );
added 2 commits
September 18, 2017 21:10
the code that checked for cell height and unit being the same was incorrect. Testing Done: calling this should be no-op, but wasn't this.grid.cellHeight( this.grid.cellHeight() );
adumesny
commented
Sep 19, 2017
| var e; | ||
| var w; | ||
| var gridstackHTML = | ||
| '<div class="grid-stack">' + |
Member
Author
There was a problem hiding this comment.
those are just formatting 2 spaces change. ignore.
| expect(grid.cellHeight()).toBe(120); | ||
| }); | ||
| }); | ||
|
|
Member
Author
There was a problem hiding this comment.
added simple test above to call cellHeight() after the fact to get more coverage. I don't know how to test to make sure grid changes height when increasing row height (80->120) which would fail to work correctly in the nested case (but might be ok otherwise).
| $('.grid-stack').gridstack(options); | ||
| var grid = $('.grid-stack').data('gridstack'); | ||
| var widgetHTML = | ||
| ' <div class="grid-stack-item">' + |
Member
Author
There was a problem hiding this comment.
again indentation fixes. ignore
| var heightData = Utils.parseHeight(val); | ||
|
|
||
| if (this.opts.cellHeightUnit === heightData.heightUnit && this.opts.height === heightData.height) { | ||
| if (this.opts.cellHeightUnit === heightData.unit && this.opts.cellHeight === heightData.height) { |
Member
Author
There was a problem hiding this comment.
code fix to use actual vars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the code that checked for cell height and unit being the same was incorrect.
Testing Done: calling this should be no-op, but wasn't
this.grid.cellHeight( this.grid.cellHeight() );
code right below uses correct names
this.opts.cellHeightUnit = heightData.unit;
this.opts.cellHeight = heightData.height;
P.S. this is why Typescript is good - you don't do those stupid JS typos....