-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Allow custom element resize handler #3142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Allow custom element resize handler #3142
Conversation
I have no idea why it shows so many changes in types.ts |
src/dd-resizable-handle.ts
Outdated
: this.host.querySelector(this.option.element) | ||
} else { | ||
this.el = document.createElement('div'); | ||
this.el.classList.add('ui-resizable-handle'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you probably should always do this. also if querySelector() fails, you still want to create our own div flow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. Fixed it.
looks like line ending formatting change (ignore white space shows just the few lines you added). I used to be on windows and likely the difference (I assume you're on mac ? ) |
Yes, yeah my VS Code and git is configured to Force LF endings. I can change that later |
Description
This changes searches for a resize handler inside the widget host and uses it instead of creating one. I have tested that in our app and it works perfectly (currently patched our version).
I can extend the readme if you point me out where to add that.
Tests fail with this, which I think is an issue with how you setup the repo:
Checklist
yarn test
)closes: #3104