Skip to content

nested grid save() incorrectly re-list children #2173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2023
Merged

nested grid save() incorrectly re-list children #2173

merged 1 commit into from
Jan 16, 2023

Conversation

adumesny
Copy link
Member

Description

  • fix Nested-Grids: grid.save() and grid.load() behaviour  #2171
  • we no longer store ops.subGrid for each nested grid. instead we parse the top grid that has this info and re-use it during create
  • save() now handles saving only layout of subGrid more efficiently (don't list options)
  • updated demo to showcase the issues

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

@adumesny
nested grid save() incorrectly re-list children
c1affaf 
* fix gridstack#2171
* we no longer store ops.subGrid for each nested grid. instead we parse the top grid that has this info and re-use it during create
* save() now handles saving only layout of subGrid more efficiently (don't list options)
* updated demo to showcase the issues
@adumesny adumesny merged commit 662d33e into gridstack:master Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nested-Grids: grid.save() and grid.load() behaviour
1 participant
@adumesny