removed jQuery from all API **BREAKING** #1158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 23, 2020 23:24
BIG, BIG change for v1.0.0 release! * all calls/return take HTLMElement | string, not JQuery anymore * the `change|removed|added` events are now using standard calls with CustomEvent (rest are still JQ based) but all share basic same callback signature still. * added `grid.on(eventName, callback)` / `grid.off(eventName)` to hide native JQ events mix * updated all demos+doc to only plain DOM manipulation (only custom drag&drop jq UI remain) * created how to upgrade to 1.0.0 section * part of #1084 **Note**: had to modify jquery and jquery-ui loading (look for [alain] comment) to be able to compile it in and still work with webpack. Also (API break) * `setColumn(N)` is now `column(N)` and new `getColumn()` (matches other set/get methods) RANT: I hate git... must have wasted half day doing a rebase from develop on jquery branch only to scrap that and start over with latest and dumping my changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BIG, BIG change for v1.0.0 release!
change|removed|addedevents are now using standard calls with CustomEvent(rest are still JQ based) but all share basic same callback signature still.
grid.on(eventName, callback)/grid.off(eventName)to hide native JQ events mixNote: had to modify jquery and jquery-ui loading (look for [alain] comment) to be able to compile it in and still work with webpack.
Also (API break)
setColumn(N)is nowcolumn(N)and newgetColumn()(matches other set/get methods)
RANT: I hate git... must have wasted half day doing a rebase from develop on jquery branch
only to scrap that and start over with latest and dumping my changes.
Checklist
yarn test)