Erronous "Failed to deserialize TOML file at line 1: unknown field `sound`"

[fkarg]

Take a look:

pars@margo ~> i3status-rs --version
i3status-rs 0.34.0
pars@margo ~> i3status-rs ~/.config/i3status/config.toml
{"version": 1, "click_events": true}
[
[{"full_text":"Failed to deserialize TOML file /home/pars/.config/i3status/config.toml at line 1: unknown field `sound`","color":"#DC322FFF","background":"#000000FF","instance":"0:","separator":false,"separator_block_width":0,"markup":"pango"}],


Failed to deserialize TOML file /home/pars/.config/i3status/config.toml at line 1: unknown field `sound`


[src/main.rs:55:9] error = NotInBlock(
    Error {
        message: Some(
            "Failed to deserialize TOML file /home/pars/.config/i3status/config.toml at line 1: unknown field `sound`",
        ),
        cause: None,
    },
)
^C⏎                                                                                                                                                
pars@margo ~ [SIGINT]> head -n 8 ~/.config/i3status/config.toml 
# i3status-rs configuration settings.
# Ansible managed

[theme]
theme = "plain"

[icons]
icons = "awesome4"

So uh. Yeah.

I do have a sound config further down (literally last in the file):

91  [[block]]
92  block = "sound"
93  driver = "pulseaudio"
94  device = "@DEFAULT_SINK@"
95  device_kind = "sink"
96 
97  [[sound.click]]
98  button = "left"
99  cmd = "pactl set-sink-mute 0 toggle"

and it very much seems like the culprit is the sound.click block, commenting it out makes everything work just fine.

Look, there may have been some changes to the 'click' mechanic since I last checked, but 'error in line 1' is just plain wrong.

(I'll figure out the changes later)

In fact, here's my full config template in case anyone wants to check something: https://github.com/fkarg/configs/blob/master/templates/i3statusconfig.j2

[bim9262]

It should be [[block.click]] not [[sound.click]]

[fkarg]

sure, but the error clearly didn't occur in line 1 -- and it was working like that for the last two years if not longer.

This issue was more so intended about the wrong location of the error instead of whatever the actual problem is.

[bim9262]

Here's a simple example: https://play.rust-lang.org/?version=stable&mode=debug&edition=2024&gist=737231a91d27e7c4116c2ea1606e34cf

Commenting out the SharedConfig in the Config body makes then span work as expected for the toml version.
For the serde_json version you can see it knows what line the error is on regardless of the SharedConfig .

I'll link this issue to the toml repo.

[bim9262]

jk, there's already an open issue: toml-rs/toml#589.

I'll follow the issue so if it's solved we can make sure to update the version of serde.
For now I suggest that if the span is (0..0) the line number is just omitted.