Skip to content

Conversation

gregswindle
Copy link
Owner

Create a PR dedicated to

  • Bumping the semantic version of parse-numeric
  • Publishing a CHANGELOG, GitHub release, and npm package

@gregswindle gregswindle added status: in-progress Work actively underway. priority: low Implement when there are no higher priority issues (or for "good first issues"). type: chore Changes that don't modify source or test files. Semver bump: PATCH (x.y.⇧) type: ci Changes to continuous integration and release workflow. Semver bump: PATCH (x.y.⇧) type: build Changes that affect the build system or external dependencies. Semver bump: PATCH (x.y.⇧) type: dependency Update or pin a third-party library. Semver bump: PATCH (x.y.⇧) type: feature Adds or enhances valuable behavior. Semver bump: MINOR (x.⇧.z) type: test Adds, fixes, or removes tests, within coverage thresholds. Semver bump: PATCH (x.y.⇧) type: docs Changes documentation, e.g., specifications, instructions. Semver bump: PATCH (x.y.⇧) labels Feb 17, 2019
@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Feb 17, 2019

Code Climate has analyzed commit e8d01a9 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@gregswindle gregswindle self-assigned this Feb 17, 2019
The **parse-numeric** module provides two features:

1. `parseNumeric` is a function that converts numeric strings into Number
    types.
2. `parseNumeric.isNumeric` evaluates a value and determines whether the
    value can be converted to a Number type.

**parse-numeric** differs from similar modules in how it evaluates
`Strings` and what it returns:

```
parseNumeric
    when given a value that is
      a {string} that represents a {number}
        ✓ will convert the {string} to a {number}
      a non-numeric {string}
        ✓ will return the original value
      a {number}
        ✓ will return the {number}
      an empty {string}
        ✓ will return the empty {string}
      {null}
        ✓ will return {null} (1ms)
      {undefined}
        ✓ will return {undefined}
```

and

```
parseNumeric.isNumeric
    ✓ returns false for non-numeric values
    ✓ returns true for numbers and numeric strings
    ✓ returns true for numbers and numeric strings
```

This commit also includes CI build features with quality gates, as well
as documentation.

GH-1
@gregswindle gregswindle removed their assignment Mar 16, 2019
@gregswindle gregswindle merged commit 652a09d into master Mar 21, 2019
@gregswindle gregswindle deleted the release-and-publish branch March 21, 2019 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low Implement when there are no higher priority issues (or for "good first issues"). status: in-progress Work actively underway. type: build Changes that affect the build system or external dependencies. Semver bump: PATCH (x.y.⇧) type: chore Changes that don't modify source or test files. Semver bump: PATCH (x.y.⇧) type: ci Changes to continuous integration and release workflow. Semver bump: PATCH (x.y.⇧) type: dependency Update or pin a third-party library. Semver bump: PATCH (x.y.⇧) type: docs Changes documentation, e.g., specifications, instructions. Semver bump: PATCH (x.y.⇧) type: feature Adds or enhances valuable behavior. Semver bump: MINOR (x.⇧.z) type: test Adds, fixes, or removes tests, within coverage thresholds. Semver bump: PATCH (x.y.⇧)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant