Skip to content

Conversation

@gregorypoole
Copy link
Owner

No description provided.

@gregorypoole gregorypoole requested a review from jskway January 16, 2020 01:58
@jskway
Copy link
Collaborator

jskway commented Jan 19, 2020

Great use of semantic HTML tags, semantic CSS class names, the display: inline-block property.
A few suggestions for improvements:

  • Make sure to put <div class="container"> on line 17 after the body tag - everything that will be displayed on the page needs to be between the body tags
  • You put a class main-image on the img on line 50 (index.html), but tried to select it using .main-img on line 123 (index.css). I think we caught this during the 1:1 review.. it's not a big deal though everyone makes typos haha
  • Once you're done styling, remember to remove the red border!

Great job overall 💯

@jskway jskway merged commit 75c7bd7 into master Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants