Skip to content

Conversation

@damienwebdev
Copy link
Member

@damienwebdev damienwebdev commented Oct 30, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Currently, the cache key for composer for Magento is non-standard, which leads to cache misses across various workflows and actions.

Fixes: N/A

What is the new behavior?

This standardizes it to a unified action to improve cache hits.

Note that I've added mode and magento_directory as inputs even though they're unused as I'd like to experiment with these in the future and adding them later would be breaking.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@damienwebdev damienwebdev changed the title Cache magento feat: add cache-magento action Oct 30, 2022
@damienwebdev damienwebdev changed the title feat: add cache-magento action feat: add cache-magento action Oct 30, 2022
@damienwebdev damienwebdev merged commit f5d43a5 into main Oct 30, 2022
@damienwebdev damienwebdev deleted the cache_magento branch October 30, 2022 16:17
@gray-bot gray-bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants