Skip to content

Conversation

saifsultanc
Copy link
Contributor

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/3089322500/89859

Summary

Missing $form object fixed, grab it from $entry because _args may have it missing it globally applied.

…ed feed not processing due to missing form object data.
Copy link

coderabbitai bot commented Sep 26, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The feed processing logic in gw-delay-feed-till-user-registration.php now explicitly retrieves the form via GFAPI::get_form using the entry’s form_id and passes the form to the integration’s maybe_process_feed method during processing.

Changes

Cohort / File(s) Summary of Changes
Feed processing update
gravity-forms/gw-delay-feed-till-user-registration.php
In process_feed, retrieve the form with GFAPI::get_form(rgar($entry, 'form_id')) and pass $form to $feed_class->maybe_process_feed($entry, $form) instead of calling without the form object.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant Plugin as GW Delay Feed Plugin
  participant GFAPI
  participant FeedClass as Feed Class

  User->>Plugin: Trigger feed processing
  Plugin->>GFAPI: get_form(entry.form_id)
  GFAPI-->>Plugin: form
  Plugin->>FeedClass: maybe_process_feed(entry, form)
  FeedClass-->>Plugin: result/status
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • veryspry
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch saif/fix/89859-fix-form-feed-not-working

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8fd3967 and dc506f1.

📒 Files selected for processing (1)
  • gravity-forms/gw-delay-feed-till-user-registration.php (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@saifsultanc saifsultanc merged commit 0b860f2 into master Sep 26, 2025
1 of 3 checks passed
@saifsultanc saifsultanc deleted the saif/fix/89859-fix-form-feed-not-working branch September 26, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant