Skip to content

Remove SASS dependency #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Remove SASS dependency #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@
"chai": "4.3.4",
"http-server": "13.0.1",
"npm-run-all": "4.1.5",
"sass": "1.38.1",
"sass-loader": "12.1.0",
"vue-jest": "^5.0.0-alpha.10",
"webpack": "5.51.1"
},
Expand Down
13 changes: 5 additions & 8 deletions src/components/TreeGrid.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,15 +112,12 @@
};
</script>

<style lang="scss">
<style>

// Embedded SCSS is the 'grtg-default-skin' skin
.grtg-wrapper.grtg-default-skin {

> .grtg {
margin: 0;
padding: 0;
}
/* Embedded CSS is the 'grtg-default-skin' skin */
.grtg-wrapper.grtg-default-skin > .grtg {
margin: 0;
padding: 0;
}

</style>
83 changes: 35 additions & 48 deletions src/components/TreeGridNode.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,60 +266,47 @@
};
</script>

<style lang="scss">

$baseHeight: 1.2rem;
$itemSpacing: 1.2rem;

// Everything's in a .grtg-wrapper (embedded SCSS is the 'grtg-default-skin' skin)
<style>
/* Everything's in a .grtg-wrapper (embedded SCSS is the 'grtg-default-skin' skin) */
.grtg-wrapper.grtg-default-skin {
--baseHeight: 1.2rem;
--itemSpacing: 1.2rem;
}

// Spacing
.grtgn-self-expander,
.grtgn-self-checkbox,
.grtgn-self-radio,
.grtgn-self-spacer,
.grtgn-self-action {
display: inline-block;
min-width: 1rem;
}

// The expander button and indicator content
.grtgn-self-expander {
padding: 0;
background: none;
border: none;
height: $baseHeight;

i.grtgn-self-expanded-indicator {
font-style: normal;

&::before {
content: '+';
}
}

&.grtgn-self-expanded {
/* Spacing */
.grtg-wrapper.grtg-default-skin .grtgn-self-expander,
.grtg-wrapper.grtg-default-skin .grtgn-self-checkbox,
.grtg-wrapper.grtg-default-skin .grtgn-self-radio,
.grtg-wrapper.grtg-default-skin .grtgn-self-spacer,
.grtg-wrapper.grtg-default-skin .grtgn-self-action {
display: inline-block;
min-width: 1rem;
}

i.grtgn-self-expanded-indicator {
/* The expander button and indicator content */
.grtg-wrapper.grtg-default-skin .grtgn-self-expander {
padding: 0;
background: none;
border: none;
height: var(--baseHeight);
}

&::before {
content: '-';
}
}
}
}
.grtg-wrapper.grtg-default-skin .grtgn-self-expander i.grtgn-self-expanded-indicator::before {
content: '+';
}

.grtgn-self-checkbox,
.grtgn-self-radio {
margin: 0 0 0 (-$itemSpacing);
}
.grtg-wrapper.grtg-default-skin .grtgn-self-expander.grtgn-self-expanded i.grtgn-self-expanded-indicator::before {
content: '-';
}

.grtgn-self-text,
.grtgn-self-label,
.grtgn-self-omit-input {
margin-left: $itemSpacing;
}
.grtg-wrapper.grtg-default-skin .grtgn-self-checkbox,
.grtg-wrapper.grtg-default-skin .grtgn-self-radio {
margin: 0 0 0 calc(-1 * var(--itemSpacing));
}

.grtg-wrapper.grtg-default-skin .grtgn-self-text,
.grtg-wrapper.grtg-default-skin .grtgn-self-label,
.grtg-wrapper.grtg-default-skin .grtgn-self-omit-input {
margin-left: var(--itemSpacing);
}
</style>
15 changes: 6 additions & 9 deletions src/components/TreeView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,16 +123,13 @@
};
</script>

<style lang="scss">
<style>

// Embedded SCSS is the 'grtv-default-skin' skin
.grtv-wrapper.grtv-default-skin {

> .grtv {
margin: 0;
padding: 0;
list-style: none;
}
/* Embedded SCSS is the 'grtv-default-skin' skin */
.grtv-wrapper.grtv-default-skin > .grtv {
margin: 0;
padding: 0;
list-style: none;
}

</style>
Loading