-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[WIP] New schema for all query/schema examples #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
506edd5
Sketch of new schema
75ff190
Add mutations and input type
3725e5d
Some updates to examples for current WIP
3a80f78
Add reviews as a very simple mutation, stick to enum for episode
6564d84
Modify schema and data
038adb5
Start replacing with new schema
c460982
Fake mutation
d729c5b
Update inline fragment docs, other fields
0299c2e
Reformat data, add search section
208a5cd
Fix bug from reformatting
3217239
Fix starship ref
2695016
Add units
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's probably better to avoid overuse of !. For one, it's noisy when teaching graphql concepts, but also it's a dangerous default state when built on languages that can throw errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the other hand, in some typed languages having everything be nullable makes it a bit annoying to work with the data. I talked to Dan and he also had a few ideas about it which basically came down to - data that involves fetches should always be nullable in case the fetch fails, but scalar fields on objects that are returned as one unit should maybe be non-null.
But that's mostly an academic concern and I agree too many
!clutter the schema.