[2020-07-02] Require Argument Uniqueness

[benjie]

Ivan: validation for type system in chapter 3 requires uniqueness of type names, field names, etc; but we forgot to specify arguments were unique. It's not an editorial change, but pretty uncontroversial.
Lee: on the topic of having a process; we need to have a reference implementation before calling it final stage.
[...]
ACTION - Ivan - implement in GraphQL.js

• assignee(s): @IvanGoncharov
• source: https://github.com/graphql/graphql-wg/blob/master/notes/2020-07-02.md#review-previous-meetings-action-items-5m-lee

---

Note: Action Item issues are reviewed and closed during Working Group
meetings.

[IvanGoncharov]

graphql-js is in feature freeze due to TS conversion.
I will work on it after 16.0.0 release.

[benjie]

@IvanGoncharov does this need a GraphQL Spec edit? If so it seems wise to slip this in before the spec cut.

[benjie]

Adding Ready for review for us to discuss at the next WG; this might not be ready to actually close.

[benjie]

Note from the GraphQL WG: we're okay doing the spec changes for this (if any) after the spec cut if need be.

[benjie]

@IvanGoncharov to create the PR, hopefully by the next GraphQL Spec Working Group. Otherwise ask someone else to champion it.

[IvanGoncharov]

Created both PRs:

• Spec: Forbid duplicating argument names graphql-spec#877
• graphql-js: Add 'UniqueArgumentDefinitionNamesRule' validation rule graphql-js#3208

[IvanGoncharov]

Sadly traveling today and can't champion it on WG.
@benjie Can you add it to the agenda, since it looks like it's totally non-controversial?