-
Notifications
You must be signed in to change notification settings - Fork 235
Closed
Labels
Description
Relates to graphql/graphql-spec#984
- 984: [long discussion around why this is a selection set and not a mutation
operation]
- Benjie: this defines serial execution of a selection set, rather than
explicitly execution of a mutation operation.- Matt's example shows an inline fragment spread, to show it's the selection
set not the operation that's important. \mutation M($newBirthday: Int, $newAddress: Int) { ... { changeBirthday(birthday: $newBirthday) { month } } changeAddress(address: $newAddress) { street } }
- Matt: Maybe runnable examples in the spec would be helpful?
- Benjie: perhaps we should add a title or caption or a non-normative note that strongly indicates this is a selection set, not an operation/document (and maybe gives an example of a full operation). \
- Matt: "selection set" is meant to imply "part of operation"
- ACTION: Roman didn't read this as a selection set but instead as a document and felt that "mutation" is missing - we need to make it crisper and clearer that we're talking about selection sets here.
- Matt: we use selection sets throughout the
documentation; this is where it jumped out to you, but if we fix it here we need
to fix it everywhere where selection sets are referenced.
- assignee(s): unknown
- source: https://github.com/graphql/graphql-wg/blob/main/notes/2022/2022-12.md#review-a-few-active-approved-simple-prs-and-merge-974-975-980-981-982-983-985
Note: Action Item issues are reviewed and closed during Working Group
meetings.