Skip to content

Editorial: fixing a number of small issues #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 27 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
413b1fb
Update Section 2 -- Language.md
rivantsov Jun 3, 2022
97c6b3c
Update Section 3 -- Type System.md
rivantsov Jun 3, 2022
e9f4c82
Update Section 4 -- Introspection.md
rivantsov Jun 3, 2022
1e67a0d
Update Section 5 -- Validation.md
rivantsov Jun 3, 2022
4578e77
Update Section 6 -- Execution.md
rivantsov Jun 3, 2022
57949e7
Update Section 5 -- Validation.md
rivantsov Jun 3, 2022
f9584af
Update Section 5 -- Validation.md
rivantsov Jun 3, 2022
5cb7011
Update Section 6 -- Execution.md
rivantsov Jun 3, 2022
4ccd1c4
Update Section 7 -- Response.md
rivantsov Jun 3, 2022
5d56a15
Update Section 2 -- Language.md
rivantsov Jun 3, 2022
9c62584
Update Section 5 -- Validation.md
rivantsov Jun 3, 2022
bd30fe1
Update Section 7 -- Response.md
rivantsov Jun 3, 2022
e5c0dc5
Update spec/Section 2 -- Language.md
rivantsov Jun 8, 2022
40cf144
Update spec/Section 2 -- Language.md
rivantsov Jun 8, 2022
a6a8e91
fixes based on Benji's feedback - reversed several fixes to discuss t…
romanivantsov Jun 9, 2022
f062daf
updates following PR feedback
romanivantsov Jun 10, 2022
c7df3e3
reverted fix for P14, to be fixed by #958
romanivantsov Jun 10, 2022
f940100
reverted fix for P14, to be fixed by #958 (+16 squashed commit)
rivantsov Jun 3, 2022
642a3cc
Merge branch 'main' of https://github.com/rivantsov/graphql-spec
rivantsov Jun 10, 2022
97b240c
Prettier
benjie Jun 11, 2022
d5b317a
minor edit, scalar->leaf
romanivantsov Jun 11, 2022
cf30b34
minor fix in 'Delivery Agnostic' section, reverted edit
romanivantsov Jun 11, 2022
5eeed04
reverted fix for Subscriptions specifies
rivantsov Jun 15, 2022
d7e4aeb
Format
leebyron Jun 16, 2022
d487992
Merge branch 'graphql:main' into main
rivantsov Jun 18, 2022
a46f76d
Merge branch 'main' into rivantsov/main
leebyron Jun 24, 2022
46dcb68
Merge branch 'main' of https://github.com/graphql/graphql-spec into g…
rivantsov Jun 30, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions spec/Section 5 -- Validation.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ or development-time tool should report validation errors and not allow the
formulation or execution of requests known to be invalid at that given point in
time.

**Type system evolution**
**Type System Evolution**

As GraphQL type system schema evolves over time by adding new types and new
fields, it is possible that a request which was previously valid could later
Expand Down Expand Up @@ -556,8 +556,8 @@ fragment safeDifferingArgs on Pet {
```

However, the field responses must be shapes which can be merged. For example,
scalar values must not differ. In this example, `someValue` might be a `String`
or an `Int`:
leaf types must not differ. In this example, `someValue` might be a `String` or
an `Int`:

```graphql counter-example
fragment conflictingDifferingResponses on Pet {
Expand Down Expand Up @@ -1093,7 +1093,7 @@ fragment ownerFragment on Human {
}
```

#### Fragment spread is possible
#### Fragment Spread is Possible

**Formal Specification**

Expand All @@ -1118,7 +1118,7 @@ type matches the type condition. They also are spread within the context of a
parent type. A fragment spread is only valid if its type condition could ever
apply within the parent type.

##### Object Spreads In Object Scope
##### Object Spreads in Object Scope

In the scope of an object type, the only valid object type fragment spread is
one that applies to the same type that is in scope.
Expand Down Expand Up @@ -1181,7 +1181,7 @@ that if one inspected the contents of the {CatOrDogNameFragment} you could note
that no valid results would ever be returned. However we do not specify this as
invalid because we only consider the fragment declaration, not its body.

##### Object Spreads In Abstract Scope
##### Object Spreads in Abstract Scope

Union or interface spreads can be used within the context of an object type
fragment, but only if the object type is one of the possible types of that
Expand Down Expand Up @@ -1971,7 +1971,7 @@ query listToNonNullList($booleanList: [Boolean]) {
This would fail validation because a `[T]` cannot be passed to a `[T]!`.
Similarly a `[T]` cannot be passed to a `[T!]`.

**Allowing optional variables when default values exist**
**Allowing Optional Variables when Default Values Exist**

A notable exception to typical variable type compatibility is allowing a
variable definition with a nullable type to be provided to a non-null location
Expand Down
6 changes: 3 additions & 3 deletions spec/Section 7 -- Response.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ If the `data` entry in the response is present (including if it is the value
{null}), the `errors` entry must be present if and only if one or more _field
error_ was raised during execution.

**Request errors**
**Request Errors**

:: A _request error_ is an error raised during a _request_ which results in no
response data. Typically raised before execution begins, a request error may
Expand All @@ -79,7 +79,7 @@ If a request error is raised, the `data` entry in the response must not be
present, the `errors` entry must include the error, and request execution should
be halted.

**Field errors**
**Field Errors**

:: A _field error_ is an error raised during the execution of a particular field
which results in partial response data. This may occur due to an internal error
Expand All @@ -92,7 +92,7 @@ is produced (see [Handling Field Errors](#sec-Handling-Field-Errors)). The
`data` entry in the response must be present. The `errors` entry should include
this error.

**Error result format**
**Error Result Format**

Every error must contain an entry with the key `message` with a string
description of the error intended for the developer as a guide to understand and
Expand Down