__Type represents all types in the system

[benjie]

In #733 (comment) @leebyron noted:

maybe we should just say: "It represents all types in the system."

I wasn't quite comfortable with what "all types" meant - whether it was inclusive or exclusive of modified types. The second paragraph implied exclusive due to the also but this didn't sit quite right with me. At first I edited it to say "all named types in the system", but felt it made the second paragraph feel a bit disjoint.

I've further modified the text and feel it's much clearer now.

I'm trying to move discussions like this out of the Tagged type spec itself, to keep the signal to noise ratio high (and figure they're useful mods for any future type additions anyway, keeping maintenance burden down).

[benjie]

Incidentally we consistently refer to "type modifier" not as the concept of List/NonNull itself, but as a specific instance of these concepts applied to a specific type; I've tried to maintain this in this PR. I'd prefer to call List/NonNull themselves "type modifiers", and List(NamedType) a "modified type" - if this seems reasonable I'm happy to make the relevant edits.

[benjie]

@leebyron Could I get your eyes on this?

[leebyron]

Thanks for the reminder. I tagged it so I don't lose it :)

Let me give this a closer read when I get a free moment

[benjie]

@leebyron Gentle nudge 😉

[benjie]

LGTM @leebyron 👍