Support for 'textDocument/hover' #217
Conversation
| * All rights reserved. | ||
| * | ||
| * This source code is licensed under the license found in the | ||
| * LICENSE file in the root directory of this source tree. |
There was a problem hiding this comment.
I have specified the wrong licence I think. graphql/codemirror-graphql is under BSD, which requires redistributions (including those with modifications) to follow the same.
Thoughts?
There was a problem hiding this comment.
We should change all license info to MIT (I believe we had a very interesting series of events because of this 😃). I haven't changed licensing info for graphql-language-service and codemirror-graphql just yet.
There was a problem hiding this comment.
That would be a worthwhile effort.
| @@ -46,6 +46,8 @@ import { | |||
|
|
|||
| import {parse, print} from 'graphql'; | |||
| import {getAutocompleteSuggestions} from './getAutocompleteSuggestions'; | |||
| import {getHoverInformation} from './getHoverInformation'; | |||
| import type {Hover} from 'vscode-languageserver-types'; | |||
There was a problem hiding this comment.
I don't have a good lint rule set up for this, but I'd encourage including type imports on the top of the list of imports.
| filePath: Uri, | ||
| ): Promise<Hover.contents> { | ||
| const projectConfig = this._graphQLConfig.getConfigForFile(filePath); | ||
| const schema = await this._graphQLCache |
There was a problem hiding this comment.
Same comment as the last PR here - could we defer fetching schema until we're absolutely in need of one?
There was a problem hiding this comment.
This is about as late as we can leave it – at this point the MessageProcessor has already validated that the hover position contains a graphql document
| * All rights reserved. | ||
| * | ||
| * This source code is licensed under the license found in the | ||
| * LICENSE file in the root directory of this source tree. |
There was a problem hiding this comment.
We should change all license info to MIT (I believe we had a very interesting series of events because of this 😃). I haven't changed licensing info for graphql-language-service and codemirror-graphql just yet.
Display field type & description information (logic ported from graphql/codemirror-graphql)
|
I'll investigate consolidating hover rendering logic between this repo and codemirror-graphql separately to this change. I think it would make sense for canonical logic to live in this repo. |
Display field type & description information (logic ported from
graphql/codemirror-graphql)
Fixes: #216