createSourceEventStream: introduce named arguments and deprecate positional arguments #3634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecates the positional arguments to `createSourceEventStream`, to be removed in the next major version.
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
yaacovCR
changed the title
|
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
|
To be backported to v16 with later PR to remove positional arguments in v17 |
n1ru4l
approved these changes
Jun 10, 2022
See open TS issue microsoft/TypeScript#31613 Marked with FIXME for when TS feature/bug fix lands upstream [This code will likely be removed in v17 prior to the feature landing, but may be retained within v16 for longer.] Similar code "works" at https://github.com/graphql/graphql-js/blob/1f8ba95c662118452bd969c6b26ba4e9050c55da/src/error/GraphQLError.ts#L47 because all the option properties are optional.
dotansimha
approved these changes
Jun 12, 2022
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Jun 14, 2022
…tional arguments BACKPORT OF graphql#3634 Deprecates the positional arguments to createSourceEventStream, to be removed in the next major version, in favor of named arguments. Motivation: 1. aligns createSourceEventStream with the other exported entrypoints graphql, execute, and subscribe 2. allows simplification of mapSourceToResponse suggested by @IvanGoncharov
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Jun 14, 2022
…tional arguments BACKPORT OF graphql#3634 Deprecates the positional arguments to createSourceEventStream, to be removed in the next major version, in favor of named arguments. Motivation: 1. aligns createSourceEventStream with the other exported entrypoints graphql, execute, and subscribe 2. allows simplification of mapSourceToResponse suggested by @IvanGoncharov
IvanGoncharov
pushed a commit
that referenced
this pull request
Jun 15, 2022
…tional arguments (#3645) BACKPORT OF #3634 Deprecates the positional arguments to createSourceEventStream, to be removed in the next major version, in favor of named arguments. Motivation: 1. aligns createSourceEventStream with the other exported entrypoints graphql, execute, and subscribe 2. allows simplification of mapSourceToResponse suggested by @IvanGoncharov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates the positional arguments to
createSourceEventStream, to be removed in the next major version, in favor of named arguments.Motivation:
createSourceEventStreamwith the other exported entrypointsgraphql,execute, andsubscribemapSourceToResponsesuggested by @IvanGoncharov