CCN experiment with execution #3510

twof · 2022-03-12T04:34:01Z

No description provided.

netlify · 2022-03-12T04:34:08Z

❌ Deploy Preview for compassionate-pike-271cb3 failed.

Name	Link
🔨 Latest commit	`bf64b72`
🔍 Latest deploy log	https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/629fc2bab774750009d92ba8

twof · 2022-03-12T04:34:32Z

src/execution/execute.ts

+  /*
+    options:
+    - pass in field nodes, so we can see which are required
+    - create a new GraphQL output type to represent required and optional fields
+
+    ? on its own marks a field nullable
+    All ! are caught by the next ?, no matter the level
+    ! + ! = !
+    ! + ? = 0
+    ! + ! + ? = 0
+
+    These are executed top down which means we can't follow a 
+  */


twof · 2022-03-12T04:34:45Z

src/execution/execute.ts

@@ -662,6 +709,7 @@ function completeValue(
      info,
      path,
      result,
+      false,


undo probably

twof · 2022-03-12T04:34:53Z

src/execution/execute.ts

@@ -714,6 +762,7 @@ function completeListValue(
  info: GraphQLResolveInfo,
  path: Path,
  result: unknown,
+  isRequiredChain: Boolean,


twof · 2022-03-12T04:36:54Z

src/language/ast.ts

+  // Note: Client Controlled Nullability is experimental
+  // and may be changed or removed in the future.
+  readonly required?: ListNullabilityNode | NullabilityDesignatorNode;
+  readonly isInRequiredChain: Boolean;


I think this will likely become a new required status instead since it feels like it's another case that isn't nullable or non nullable, but impacts null propagation rules all the same.

twof · 2022-03-12T04:37:35Z

src/language/parser.ts

+    // const isRequiredChain: Boolean = ((selectionSet?.selections) ?? [])
+    //   .reduce((accumulator: Boolean, element: SelectionNode) => {
+    //   if (accumulator) {
+    //     return true
+    //   } else if ()
+    // })


twof · 2022-03-12T04:38:37Z

src/language/parser.ts

+      for (const selection of selectionSet?.selections ?? []) {
+        const field = selection as FieldNode;
+        if (selection.kind == Kind.FIELD) {
+          if (field.isInRequiredChain) {
+            isRequiredChain = true;
+            break;
+          }
+        }


see if TS has some contains(where:) method that we can replace this with

github-actions · 2022-03-14T02:53:00Z

The latest changes of this PR are available on NPM as
graphql@16.3.0-canary.pr.3510.942fbd8ea3d803e74908fabecbe03dfaefe3e5c8
Note: no gurantees provided so please use your own discretion.

Also you can depend on latest version built from this PR:
npm install --save graphql@canary-pr-3510

github-actions · 2022-03-14T18:18:24Z

The latest changes of this PR are available on NPM as
graphql@16.3.0-canary.pr.3510.5099f4491dc2a35a3e4a0270a55e2a228c15f13b
Note: no gurantees provided so please use your own discretion.

Also you can depend on latest version built from this PR:
npm install --save graphql@canary-pr-3510

twof · 2022-03-14T18:52:42Z

src/execution/execute.ts

+    options:
+    - pass in field nodes, so we can see which are required
+    - create a new GraphQL output type to represent required and optional fields
+
+    ? on its own marks a field nullable
+    All ! are caught by the next ?, no matter the level
+    ! + ! = !
+    ! + ? = 0
+    ! + ! + ? = 0
+
+    if propagation path is undefined, that could mean that there are no required fields
+    or that could mean that there are no optional fields. Path can't represent an empty path
+  */


twof · 2022-03-17T00:41:23Z

src/utilities/applyRequiredStatus.ts

+
+  while (isListType(getNullableType(typeStack[typeStack.length - 1]))) {
+    const list = assertListType(
+      getNullableType(typeStack[typeStack.length - 1]),
+    );
+    const elementType = list.ofType as GraphQLOutputType;
+    typeStack.push(elementType);
+  }
+


Only populate typeStack after we've confirmed that nullabilityNode exists to improve performance

twof · 2022-04-27T19:34:53Z

src/utilities/index.ts

@@ -104,4 +104,4 @@ export type { BreakingChange, DangerousChange } from './findBreakingChanges';
 // Wrapper type that contains DocumentNode and types that can be deduced from it.
 export type { TypedQueryDocumentNode } from './typedQueryDocumentNode';

-export { modifiedOutputType } from './applyRequiredStatus';
+export { applyRequiredStatus as modifiedOutputType } from './applyRequiredStatus';


Not sure why I exported this under a different name. Probably revert.

twof · 2022-05-13T06:19:20Z

src/validation/rules/RequiredStatusOnFieldMatchesDefinitionRule.ts

+/**
+ * List element nullability designators need to use a depth that is the same as or less than the
+ *   type of the field it's applied to.
+ *
+ * Otherwise the GraphQL document is invalid.
+ *
+ * See https://spec.graphql.org/draft/#sec-Field-Selections
+ */


This validation step isn't accurate. Update to include loosened rules.

twof · 2022-05-13T20:38:07Z

src/utilities/applyRequiredStatus.ts

+  };
+
+  const modified = visit(nullabilityNode, applyStatusReducer);
+  // modifiers must be exactly the same depth as the field type


Designators

calvincestari · 2023-05-09T19:02:44Z

Hi @twof, are you still championing this work through the GraphQL WG? I'm open to chat about it and contribute to getting this moving forward again.

twof · 2023-07-04T18:39:29Z

Hi @twof, are you still championing this work through the GraphQL WG? I'm open to chat about it and contribute to getting this moving forward again.

Hi @calvincestari! Took me a bit to see this sorry about that. If you're still interested, can you message me in the #client-controlled-nullability channel on the graphql discord? I passed the project on to @fotoetienne but I'm sure he'd appreciate the help.

calvincestari · 2023-07-05T05:52:28Z

Hi @twof, are you still championing this work through the GraphQL WG? I'm open to chat about it and contribute to getting this moving forward again.

Hi @calvincestari! Took me a bit to see this sorry about that. If you're still interested, can you message me in the #client-controlled-nullability channel on the graphql discord? I passed the project on to @fotoetienne but I'm sure he'd appreciate the help.

Will do. I'm away this week but I'll follow up next week.

twof added 15 commits February 22, 2022 12:44

bang and question mark introduced, all tests passing

f086eb9

npm test passes

8c62ac9

introduce experimental flag

b34384f

experimental features marked and tests passing

2e7052e

prettier and npm test passing

2a718cf

switch parser-test formatting

09de547

prettier

b20b004

rename modifier to designator

d37b863

required designators in their place

ae8eaee

all but visitor test passing

fa53703

visitor test passing

ee57f87

visitor test and npm test passing

6e30de3

finish rebase

64c65ba

new exports

c9f6436

fix prettier

662180b

twof commented Mar 12, 2022

View reviewed changes

src/execution/execute.ts Outdated

@@ -662,6 +709,7 @@ function completeValue(

info,

path,

result,

false,

Copy link

Contributor Author

twof Mar 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undo probably

twof commented Mar 12, 2022

View reviewed changes

twof mentioned this pull request Mar 14, 2022

RFC: Client Controlled Nullability graphql/graphql-spec#895

Closed

twof commented Mar 14, 2022

View reviewed changes

twof commented Mar 17, 2022

View reviewed changes

This was referenced Apr 11, 2022

[RFC] Client Controlled Nullability experiment implementation w/o execution #3418

Merged

[Do Not Merge] Stable branch for experimental CCN implementation #3535

Closed

twof commented Apr 27, 2022

View reviewed changes

twof added 2 commits April 27, 2022 12:38

pull some improvements over from the execution branch

1d25a2e

More test coverage

4243708

n1ru4l mentioned this pull request May 5, 2022

implement support for client-side-nullability dotansimha/graphql-code-generator#7824

Open

Review changes

bb68261

twof commented May 13, 2022

View reviewed changes

twof added 16 commits May 31, 2022 15:44

add execution

778fb77

execution tests passing

e661264

tests passing, imperfect coverage

992706a

new tests, tracked down null propagation logic

2793a94

null propagating to nearst ? as expected

33ee7bc

null propagating through fragments

30a0e05

remove parse step required chain logic

239de74

all tests passing

b8ac739

all tests passing with 100% coverage

f705d5d

list syntax restrictions loosened

ff3234d

test designator on query

4e62ac6

list syntax rules loosened, tests passing and space performance improved

0511255

more space efficiency

70e6161

remote execution context change

98b3816

finish rebase

31c4296

finish rebase. Tests passing.

40df6bc

twof force-pushed the CCNExperimentWithExecution branch from a3bef80 to 40df6bc Compare June 1, 2022 00:12

Merge branch 'main' into CCNExperimentWithExecution

bf64b72

This was referenced Jul 11, 2023

Update JS frontend to use graphql-js (latest 17.x.x) without support for CCN apollographql/apollo-ios#3113

Closed

Maybe: Refactor CCN PR on top of graphql-js latest 17.x.x release apollographql/apollo-ios#3114

Closed

twof closed this Dec 20, 2023

@@ @@ -662,6 +709,7 @@ function completeValue( @@
                     info,
                     path,
                     result,
+                    false,

CCN experiment with execution #3510

CCN experiment with execution #3510

Uh oh!

Conversation

twof commented Mar 12, 2022

Uh oh!

netlify bot commented Mar 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Deploy Preview for compassionate-pike-271cb3 failed.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 14, 2022

Uh oh!

github-actions bot commented Mar 14, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

twof May 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

calvincestari commented May 9, 2023

Uh oh!

twof commented Jul 4, 2023

Uh oh!

calvincestari commented Jul 5, 2023

Uh oh!

Uh oh!

netlify bot commented Mar 12, 2022 •

edited

Loading

twof May 13, 2022 •

edited

Loading