-
Notifications
You must be signed in to change notification settings - Fork 29
Add audit for variable coercion failure #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add audit for variable coercion failure #58
Conversation
Hey sorry, I haven't forgotten about this. Am currently on a break until next week - I'll review this properly then, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase this PR on main
because #29 should be fixed now.
44f503b
to
3f73b45
Compare
@enisdenjo looks like the same needs to be done here as well?
|
Not really, the CI does not change anything - its just checks. |
@enisdenjo ok. I only said that because the some of the statuses were expected but didn't seem to be running. It looks like everything's passed now. |
Yeah, the workflows have to be triggered manually for first-time contributors. But I think I'll add it still to avoid having the WFs manipulated by PRs. 🤔 |
e38aac3
to
9ad1f96
Compare
Thank you! This is great, I just added the same test but for |
🎉 This PR is included in version 1.17.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
From the spec:
Fixes #57
Should I be also "should not"ing the request execution (and how can I accomplish that)?
I'm assuming I don't update the audit results (it looks like that's in a GH workflow) but let me know if there are any other changes that should come with PR.