Better custom scalar validation #243
Conversation
jbblanchet
commented
Feb 19, 2018
jbblanchet
commented
- Use parseLiteral to validate the custom scalar. Should work with validation changes introduced in graphql-js v12: (Potentially Breaking) Allow serializing scalars as null. graphql-js#1104
- Fix linting rule conflicting with pretty-check
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Nevermind, I thought the custom scalars serializer and parsers were sent to the client, but they're not, so this won't work. |
